Activity From 09/13/2024 to 09/19/2024
09/19/2024 11:43 PM Bug #20734 (Closed): Test failure at FreeBSD 14.1 @nobu fixed this at https://.com/ruby/ruby/commit/dc8c382266b056fa51408806478218f5230fbce2 hsbt (Hiroshi SHIBATA) 04:20 AM Bug #20734 (Assigned): Test failure at FreeBSD 14.1 I confirmed that https://.com/ruby/ruby/commit/63cbe3f6ac9feb44a2e43b1f853e2ca7e049316c is not working with Fre... hsbt (Hiroshi SHIBATA) 10:53 PM Feature #20756 (Rejected): Introduce Boolean class #12515 is an enough reason to reject this idea. matz (Yukihiro Matsumoto) 09:50 PM Feature #20756 (Rejected): Introduce Boolean class Hello All, kbrock (Keenan Brock) 06:51 PM Revision 2230ac4a (git): Fix potentially missing write barrier in iseq_build_kw We're writing objects to the iseq but not firing the write barrier. peterzhu2118 (Peter Zhu) 06:51 PM Revision ead280fe (git): Replace RB_OBJ_WRITTEN with RB_OBJ_WRITE in iseq_set_arguments_keywords peterzhu2118 (Peter Zhu) 06:51 PM Revision 7a2b5ed5 (git): Replace RB_OBJ_WRITTEN with RB_OBJ_WRITE in pm_compile_scope_node peterzhu2118 (Peter Zhu) 05:14 PM Revision dc644482 (git): Remove an unused variable k0kubun (Takashi Kokubun) 04:39 PM Feature #20750: Allow rb_thread_call_with_gvl to work when thread already has GVL Hello, kbrock (Keenan Brock) 03:55 PM Feature #20750: Allow rb_thread_call_with_gvl to work when thread already has GVL Benoit, kbrock (Keenan Brock) 04:10 PM Revision d9981beb (git): [DOC] Improve docs for GC.latest_gc_info peterzhu2118 (Peter Zhu) 03:28 PM Misc #20728: Propose Eileen Uchitelle as a core committer Thank you for nominating me Kevin, and the support those who have commented so far. It would be an honor to be accept... eileencodes (Eileen Uchitelle) 02:34 PM Bug #20716 (Closed): Different instance_method behavior in Ruby 2.7 and Ruby 3.x Applied in changeset commit:git|6118e8a47394409b53164b60e79fadf348b97db3. jeremyevans (Jeremy Evans) 02:34 PM Revision 6118e8a4 (git): Fix method caching bug when including/prepend module A that prepends module B Fix by always adding the generated iclass to the subclasses list, jeremyevans (Jeremy Evans) 12:21 PM Revision 167fba52 (git): Remove rb_gc_impl_initial_stress_set peterzhu2118 (Peter Zhu) 09:08 AM Revision dc8c3822 (git): Fix bug at fork on FreeBSD The main thread in a forked process appears not to own the read-write nobu (Nobuyoshi Nakada) 09:06 AM Revision d9f6e326 (git): Don't update lockfile with bundler/inline hsbt (Hiroshi SHIBATA) 07:23 AM Revision 46ee05f0 (git): Added missing block arg hsbt (Hiroshi SHIBATA) 07:12 AM Revision 59db92a1 (git): [ruby/set] 2024 https://.com/ruby/set/commit/ea95c5a3d2 Akinori MUSHA 07:11 AM Revision e53d2f20 (git): [ruby/set] Reword the document for to_a and clarify the implementation notes ref. https://.com/ruby/ruby/pull/11453 Akinori MUSHA 05:59 AM Revision 24b587e7 (git): Use ppc64le coroutines for powerpc64-freebsd* There is nothing endianness-related in ppc64le and all the tests pass on both ucontext and ppc64le coroutines on powe... Piotr Kubaj 05:59 AM Revision c362206a (git): Use ppc64le coroutines on powerpc64le-freebsd* Only one ractor-related test fails, but it also fails with ucontext. Piotr Kubaj 05:33 AM Revision c193ca52 (git): Adjust indent [ci skip] nobu (Nobuyoshi Nakada) 04:29 AM Bug #20607 (Closed): Exception messages are inconsistent when thread-local variables are accessed Applied in changeset commit:git|8dc0d2904a7d859b463a3f44ac73e5d4540a1cc1. jeremyevans (Jeremy Evans) 04:29 AM Revision 8dc0d290 (git): Update exception message in string_for_symbol This is a static function only called in two places (rb_to_id and jeremyevans (Jeremy Evans) 09/18/2024 11:55 PM Bug #20597 (Closed): `eval('break if false')` should raise SyntaxError but retuns nil Applied in changeset commit:git|268c72377b06b7d84a0998ca241340d0f58768f6. jeremyevans (Jeremy Evans) 11:54 PM Revision 268c7237 (git): Raise a compile error for break/next/redo inside eval in cases where it is optimized away In cases where break/next/redo are not valid syntax, they should jeremyevans (Jeremy Evans) 08:47 PM Revision 984a791d (git): [DOC] Escape the word GC in GC.config peterzhu2118 (Peter Zhu) 07:46 PM Revision 29f2cb83 (git): Fix evaluation order issue in f(**h, &h.delete(key)) Previously, this would delete the key in `h` before keyword jeremyevans (Jeremy Evans) 07:18 PM Revision e358104e (git): [DOC] Fix formatting for ways to create Range objects peterzhu2118 (Peter Zhu) 06:26 PM Revision 9c12c39e (git): Revert "Fix evaluation order issue in f(**h, &h.delete(key))" This reverts commit 07d3bf4832532ae7446c9a6924d79aed60a7a9a5. jeremyevans (Jeremy Evans) 06:18 PM Bug #20640 (Closed): Evaluation Order Issue in f(**h, &h.delete(key)) Applied in changeset commit:git|07d3bf4832532ae7446c9a6924d79aed60a7a9a5. jeremyevans (Jeremy Evans) 06:18 PM Revision 07d3bf48 (git): Fix evaluation order issue in f(**h, &h.delete(key)) Previously, this would delete the key in h before keyword jeremyevans (Jeremy Evans) 04:58 PM Revision f8e1c93f (git): Move more of GC.latest_gc_info into Ruby peterzhu2118 (Peter Zhu) 04:42 PM Bug #20740 (Closed): prism_compile coding issue for PM_FORWARDING_SUPER_NODE Applied in changeset commit:git|c14b60630d680addd5b4ef9c9b159a26a5446483. luke-gru (Luke Gruber) 04:42 PM Revision 461c4896 (git): [rubygems/rubygems] Add a note about when hack can be removed https://.com/rubygems/rubygems/commit/058b29fe98 deivid (David Rodríguez) 04:42 PM Revision ae214be9 (git): [rubygems/rubygems] Fix TODO https://.com/rubygems/rubygems/commit/2cd13005f6 deivid (David Rodríguez) 04:42 PM Revision 47db8bc0 (git): [rubygems/rubygems] Stop fighting with ourselves https://.com/rubygems/rubygems/commit/7cf2fdcfa1 deivid (David Rodríguez) 03:52 PM Revision c14b6063 (git): Fix coding issue in prism_compile.c Make sure to set back `ISEQ_COMPILE_DATA(iseq)->current_block` for luke-gru (Luke Gruber) 03:52 PM Revision 96da3f16 (git): [ruby/prism] Allow returns in default parameter values https://.com/ruby/prism/commit/e98ea15596 kddnewton (Kevin Newton) 02:18 PM Revision 5df5eba4 (git): Change rb_gc_impl_get_measure_total_time to return a bool peterzhu2118 (Peter Zhu) 01:29 PM Bug #20755 (Closed): IO::Buffer#transfer transfers mutable reference to String's memory but not lock ownership `IO::Buffer.for` with a block yields a mutable IO::Buffer that shares underlying memory with a mutable String. While ... hanazuki (Kasumi Hanazuki) 12:14 PM Bug #20754: [doc] `Hash::new` is missing from rdoc for 3.4 What a simple fix, now I know myself. Thank you! Earlopain (Earlopain _) 12:06 PM Bug #20754 (Closed): [doc] `Hash::new` is missing from rdoc for 3.4 Applied in changeset commit:git|f82618578666ee720bdc0ec8e4aeace541f2d953. nobu (Nobuyoshi Nakada) 11:40 AM Bug #20754 (Closed): [doc] `Hash::new` is missing from rdoc for 3.4 I was interested in the `capacity` argument added in https://.com/ruby/ruby/pull/10357 but found any reference ... Earlopain (Earlopain _) 12:03 PM Revision f8261857 (git): [Bug #20754] Document in hash.rb nobu (Nobuyoshi Nakada) 12:02 PM Misc #20717: DevMeeting-2024-10-03 * [Feature #20750] Expose ruby_thread_has_gvl_p in ruby/thread.h (eregon) Eregon (Benoit Daloze) 12:00 PM Feature #20750: Allow rb_thread_call_with_gvl to work when thread already has GVL OK the issue/bug is Eregon (Benoit Daloze) 11:56 AM Feature #20750: Allow rb_thread_call_with_gvl to work when thread already has GVL So what is the concrete issue if the pattern above is replaced by `rb_thread_call_with_gvl(method_call, &context);`? Eregon (Benoit Daloze) 11:48 AM Bug #20745: IO::Buffer#copy triggers UB when src/dest buffers overlap I don't think we can legitimately expose an API that can lead to a crash if used incorrectly. byroot (Jean Boussier) 08:03 AM Bug #20745: IO::Buffer#copy triggers UB when src/dest buffers overlap If this is an intentional restriction to gain performance, I would like to propose adding documentation that the meth... hanazuki (Kasumi Hanazuki) 02:19 AM Bug #20745: IO::Buffer#copy triggers UB when src/dest buffers overlap Since the doc says "using `memcpy`", it may be intentionally undetermined/unsupported. nobu (Nobuyoshi Nakada) 10:17 AM Bug #20753 (Closed): [doc] IO::Buffer examples try to write into readonly buffer returned from IO::Buffer.for `IO::Buffer.for` without a block returns a readonly `IO::Buffer`. Some examples in the documentation for `IO::Buffer`... hanazuki (Kasumi Hanazuki) 10:00 AM Bug #20752: IO::Buffer#slice creates mutable IO::Buffer instance that points to readonly memory (e.g. fronzen String) It results in bus errors with 3.1 and 3.2. nobu (Nobuyoshi Nakada) 09:38 AM Bug #20752 (Closed): IO::Buffer#slice creates mutable IO::Buffer instance that points to readonly memory (e.g. fronzen String) ```irb hanazuki (Kasumi Hanazuki) 06:30 AM Feature #20309: Bundled gems for Ruby 3.5 Eregon (Benoit Daloze) wrote in #note-38: vo.x (Vit Ondruch) 02:16 AM Revision 4797b070 (git): Prevent a warning (retry) ``` mame (Yusuke Endoh) 12:59 AM Revision 94a17f32 (git): Detect existing Visual Studio instances using `vswhere.exe` https://learn.microsoft.com/en-us/visualstudio/install/tools-for-managing-visual-studio-instances?view=vs-2022#using-... nobu (Nobuyoshi Nakada) 12:06 AM Revision 7c4b0284 (git): YJIT: Accept key for runtime_stats to return only that stat (#11536) Randy Stauner 09/17/2024 11:49 PM Bug #20751 (Closed): Regression in Prism related to use of return in default argument values kddnewton (Kevin Newton) wrote in #note-2: jeremyevans0 (Jeremy Evans) 11:37 PM Bug #20751: Regression in Prism related to use of return in default argument values I believe this was fixed this morning. Could you double-check that this is still an issue? kddnewton (Kevin Newton) 11:19 PM Bug #20751 (Closed): Regression in Prism related to use of return in default argument values All versions of parse.y dating at least back to Ruby 1.8.7, and Prism in both Ruby 3.3.5 and 3.4.0preview1, correctly... jeremyevans0 (Jeremy Evans) 10:34 PM Feature #20750: Allow rb_thread_call_with_gvl to work when thread already has GVL Hello Benoit, kbrock (Keenan Brock) 08:03 PM Feature #20750: Allow rb_thread_call_with_gvl to work when thread already has GVL Note that the majority of the search results are just CRuby using it, and not detecting it's effectively copie... Eregon (Benoit Daloze) 04:52 PM Feature #20750 (Open): Allow rb_thread_call_with_gvl to work when thread already has GVL Hello All, kbrock (Keenan Brock) 10:12 PM Revision 39679d7f (git): [ruby/uri] Fix spelling of "cannot" https://.com/ruby/uri/commit/77241d6508 deivid (David Rodríguez) 08:35 PM Revision 5307c65c (git): Make rb_gc_impl_set_measure_total_time return void peterzhu2118 (Peter Zhu) 08:09 PM Revision b203e667 (git): [rubygems/rubygems] Fix spelling, it's "cannot" rather than "can not" https://.com/rubygems/rubygems/commit/3434f094a2 deivid (David Rodríguez) 07:22 PM Revision dc61c7fc (git): Rename rb_gc_impl_get_profile_total_time to rb_gc_impl_get_total_time peterzhu2118 (Peter Zhu) 07:22 PM Revision 2af080bd (git): Change rb_gc_impl_get_profile_total_time to return unsigned long long peterzhu2118 (Peter Zhu) 07:22 PM Revision 5de7517b (git): Use unsigned long long for marking and sweeping time peterzhu2118 (Peter Zhu) 06:47 PM Revision 748933aa (git): [ruby/prism] Accept "do" blocks in some parameter default values https://.com/ruby/prism/commit/6d7b734dbe kddnewton (Kevin Newton) 02:39 PM Feature #20742: Trying to assign to a variable in statement modifier should emit a warning Earlopain (A S) wrote in #note-5: jeremyevans0 (Jeremy Evans) 09:00 AM Feature #20742: Trying to assign to a variable in statement modifier should emit a warning Should this just work? If I do: Earlopain (Earlopain _) 02:34 PM Revision 0160dafc (git): Replace all GC.disable with EnvUtil.without_gc peterzhu2118 (Peter Zhu) 02:07 PM Revision 82151a86 (git): Fix a typo, sorry! mame (Yusuke Endoh) 01:52 PM Revision fd5e5839 (git): Prevent two warnings ``` mame (Yusuke Endoh) 12:40 PM Bug #20749: Error message not shown in output with prism This was an issue with the error_highlight gem. I made a PR here: https://.com/ruby/error_highlight/pull/48 luke-gru (Luke Gruber) 12:37 PM Feature #20309: Bundled gems for Ruby 3.5 vo.x (Vit Ondruch) wrote in #note-35: Eregon (Benoit Daloze) 09:40 AM Feature #20309: Bundled gems for Ruby 3.5 > I don't think so. Bundler should provide that feature for like debug, stackprof and irb. I and @mame (Yusuke Endoh)... deivid (David Rodríguez) 08:53 AM Feature #20309: Bundled gems for Ruby 3.5 >The fact that we want binding.irb to work regardless of being in a bundle exec context or not feels like a sign that... hsbt (Hiroshi SHIBATA) 11:10 AM Revision cf063c00 (git): [rubygems/rubygems] Bump rubies in CI to 3.3.5 A spec needed changes because now loading the default `json` prints a deivid (David Rodríguez) 08:48 AM Bug #20734: Test failure at FreeBSD 14.1 I could build 4ca588eede and `git clean -fxd`. hsbt (Hiroshi SHIBATA) 08:37 AM Bug #20631: Build failure with Xcode 16 beta and macOS 15 (Sequoia) Beta `Process.daemon` is working fine at macOS 15.1 beta3 and Xcode 16 RC. hsbt (Hiroshi SHIBATA) 07:16 AM Revision 1ecac5d4 (git): TestProcess#test_daemon_noclose is working fine with macOS 15.1 beta3 and Xcode 16 RC hsbt (Hiroshi SHIBATA) 06:44 AM Revision 95f08f2b (git): Skip failing examples related with https://.com/ruby/ruby/commit/d81b0588bb3c97167d1f7e2d2a74185e0c19b68c hsbt (Hiroshi SHIBATA) 06:37 AM Revision c0116860 (git): Removed accidentally commit for snapshot file of prism hsbt (Hiroshi SHIBATA) 06:12 AM Revision d81b0588 (git): [ruby/strscan] Accept String as a pattern at non head (https://.com/ruby/strscan/pull/106) naitoh (Jun NAITOH) 05:41 AM Revision 7d80c139 (git): Unlock parallel_tests deivid (David Rodríguez) 05:39 AM Revision 80e934c2 (git): [rubygems/rubygems] Fix `--local` hitting the network when default gems are included https://.com/rubygems/rubygems/commit/b9a2d4d539 deivid (David Rodríguez) 05:39 AM Revision 335d6309 (git): [rubygems/rubygems] Improve spec The behavior it's testing is independent from the bundle path being deivid (David Rodríguez) 05:39 AM Revision 166cde7d (git): [rubygems/rubygems] Fix spec to setup a default gem correctly Looking at the description is something that used to be done a long time deivid (David Rodríguez) 05:39 AM Revision 7428709d (git): [rubygems/rubygems] Inline a private method Removes an (in my opinion) excessive indirection and handles options deivid (David Rodríguez) 05:39 AM Revision 7e0934d3 (git): [rubygems/rubygems] Consistently access install options through symbol keys https://.com/rubygems/rubygems/commit/7ddf1dc70a deivid (David Rodríguez) 05:15 AM Revision 70111fcc (git): Prevent a warning due to error recovery of prism mame (Yusuke Endoh) 05:10 AM Revision d90da940 (git): Prevent warnings for RubyVM::AbstractSyntaxTree.parse in test_ast.rb mame (Yusuke Endoh) 04:56 AM Revision d84b062b (git): Prevent warning: assigned but unused variable - message mame (Yusuke Endoh) 03:54 AM Revision 4ca588ee (git): Bump /codeql-action from 3.26.6 to 3.26.7 Bumps [/codeql-action](https://.com//codeql-action) from 3.26.6 to 3.26.7. dependabot[bot] 03:52 AM Revision bb2d2473 (git): [DOC] Fix autoload method formatting itsNikolay (Nikolay Ponomarev) 03:46 AM Revision bb7025b7 (git): Activate irb if irb is bundled gems hsbt (Hiroshi SHIBATA) 03:44 AM Revision 76d927f8 (git): Prevent prism warnings in syntax exhaustive tests [Bug #20736] mame (Yusuke Endoh) 12:28 AM Revision 4e59e7d3 (git): [Bug #20737] Do not warn default gems to be promoted in Ruby 3.5 (#11613) hsbt (Hiroshi SHIBATA) 12:11 AM Bug #20723 (Closed): `IO#close` is broken on Ruby 3.3+ when using the Fiber scheduler. Applied in changeset commit:git|e08d5239b68ad61a731f4938cf963e37a5e88c25. kjtsanaktsidis (KJ Tsanaktsidis) 12:11 AM Revision e08d5239 (git): Ensure fiber scheduler is woken up when close interrupts read If one thread is reading and another closes that socket, the close kjtsanaktsidis (KJ Tsanaktsidis) 09/16/2024 08:35 PM Feature #20309: Bundled gems for Ruby 3.5 Eregon (Benoit Daloze) wrote in #note-34: vo.x (Vit Ondruch) 10:27 AM Feature #20309: Bundled gems for Ruby 3.5 There is an additional issue with making fiddle a bundled gem: it means any usage now must have libffi headers availa... Eregon (Benoit Daloze) 07:58 PM Revision 50d4840b (git): Move desired_compaction_pages_i inside of GC_CAN_COMPILE_COMPACTION Fixes the following warning on WebAssembly: peterzhu2118 (Peter Zhu) 07:55 PM Bug #20747 (Closed): [prism] regression in retry precedence kddnewton (Kevin Newton) 07:28 PM Bug #20747: [prism] regression in retry precedence I have opened a PR to fix this: https://.com/ruby/prism/pull/3073. kddnewton (Kevin Newton) 08:26 AM Bug #20747 (Closed): [prism] regression in retry precedence Since prism has been made the default, our test suite now fail to boot with the following error: byroot (Jean Boussier) 07:55 PM Revision 7e2ae30f (git): [ruby/prism] Handle retry doubly nested under rescue Fixes [Bug #20747] kddnewton (Kevin Newton) 06:58 PM Bug #20744 (Closed): syntax error found (SyntaxError) `UTF-8 mixed within US-ASCII source` reported Ruby with Prism parser Applied in changeset commit:git|2ea1950510003dbce5a761a712039ed69fa499f2. kddnewton (Kevin Newton) 06:41 PM Bug #20744: syntax error found (SyntaxError) `UTF-8 mixed within US-ASCII source` reported Ruby with Prism parser I have opened a PR to fix this. kddnewton (Kevin Newton) 12:49 PM Bug #20744: syntax error found (SyntaxError) `UTF-8 mixed within US-ASCII source` reported Ruby with Prism parser Thank you for the report, I will take a look. kddnewton (Kevin Newton) 07:07 AM Bug #20744: syntax error found (SyntaxError) `UTF-8 mixed within US-ASCII source` reported Ruby with Prism parser I'm unsure if this is the same case as Rails, but I found a reproduce code. ima1zumi (Mari Imaizumi) 04:33 AM Bug #20744 (Closed): syntax error found (SyntaxError) `UTF-8 mixed within US-ASCII source` reported Ruby with Prism parser I'm reporting this issue based on Rails Nightly CI against Ruby 3.4.0dev. yahonda (Yasuo Honda) 06:57 PM Revision 2ea19505 (git): [ruby/prism] Do not explicit encoding Fixes [Bug #20744] kddnewton (Kevin Newton) 06:38 PM Revision 1e53e462 (git): Don't export unnecessary string functions These functions are not used publicly, so we don't need to export them. peterzhu2118 (Peter Zhu) 06:31 PM Bug #20741 (Closed): RubyVM::InstructionSequence.compile emits a wrong warning (prism?) kddnewton (Kevin Newton) 03:04 PM Bug #20741: RubyVM::InstructionSequence.compile emits a wrong warning (prism?) I have submitted a PR that will fix this https://.com/ruby/ruby/pull/11632. kddnewton (Kevin Newton) 06:31 PM Revision 2beb4c6e (git): [PRISM] Assume an eval context for RubyVM::ISEQ compile Fixes [Bug #20741] kddnewton (Kevin Newton) 05:36 PM Revision 6c4ce726 (git): [ruby/irb] Use InstructionSequence#script_lines to get method source (https://.com/ruby/irb/pull/1005) tompng (tomoya ishida) 04:33 PM Revision 1c3981cb (git): [DOC] Tweaks for Array#select! burdettelamar (Burdette Lamar) 04:33 PM Revision 4e17fa29 (git): Tweaks or Array#select burdettelamar (Burdette Lamar) 04:14 PM Misc #20717: DevMeeting-2024-10-03 * [Misc #20728] Add eileencodes as a core committer tenderlovemaking (Aaron Patterson) 08:05 AM Misc #20717: DevMeeting-2024-10-03 * [Misc #20746] Request to migrate the `json` gem from `flori/json` repository to `ruby/json` (byroot) byroot (Jean Boussier) 03:54 PM Feature #20742: Trying to assign to a variable in statement modifier should emit a warning Actually, the pattern is fairly common, I should have searched for `unless` usage in addition to `if`: jeremyevans0 (Jeremy Evans) 03:48 PM Feature #20742: Trying to assign to a variable in statement modifier should emit a warning Eregon (Benoit Daloze) wrote in #note-2: jeremyevans0 (Jeremy Evans) 11:42 AM Feature #20742: Trying to assign to a variable in statement modifier should emit a warning jeremyevans0 (Jeremy Evans) wrote in #note-1: Eregon (Benoit Daloze) 03:54 PM Bug #20748 (Closed): Issue with defined? given method call with block in prism compiler Applied in changeset commit:git|1e52dde82af10f2a2ec648b34dce30bec4154245. kddnewton (Kevin Newton) 03:29 PM Bug #20748: Issue with defined? given method call with block in prism compiler I agree it's weird but it could cause an incompatibility I guess, `defined?()` is a weird one for sure. luke-gru (Luke Gruber) 03:16 PM Bug #20748: Issue with defined? given method call with block in prism compiler I have opened a PR for this to match the behavior exactly, but I will say I think Prism's behavior is actually correc... kddnewton (Kevin Newton) 01:59 PM Bug #20748 (Closed): Issue with defined? given method call with block in prism compiler test.rb luke-gru (Luke Gruber) 03:53 PM Revision 1e52dde8 (git): [PRISM] Match defined behavior for explicit block Fixes [Bug #20748] kddnewton (Kevin Newton) 02:41 PM Bug #20237 (Closed): Unable to unshare(CLONE_NEWUSER) in Linux because of timer thread jeremyevans0 (Jeremy Evans) 06:42 AM Bug #20237: Unable to unshare(CLONE_NEWUSER) in Linux because of timer thread Thank you @ko1 for sharing the current situation. I'm fine with closing this ticket as it is due to the design decisi... hanazuki (Kasumi Hanazuki) 02:16 PM Bug #20749 (Closed): Error message not shown in output with prism test.rb: luke-gru (Luke Gruber) 01:27 PM Revision 50564f88 (git): ASAN unpoison whole heap page after adding to size pool peterzhu2118 (Peter Zhu) 01:27 PM Revision 46ba3752 (git): Don't return inside of asan_unpoisoning_object peterzhu2118 (Peter Zhu) 01:27 PM Revision c5a782df (git): Replace with asan_unpoisoning_object peterzhu2118 (Peter Zhu) 01:13 PM Revision f4f46af9 (git): Complete spec Co-authored-by: Vít Ondruch <[email protected] > deivid (David Rodríguez) 01:13 PM Revision 2bfeedc0 (git): [rubygems/rubygems] Simplify handling default gem caching By the time `cached_gem` is called, default gem cache has already been deivid (David Rodríguez) 12:44 PM Revision d57bc870 (git): [PRISM] Remove snapshot testing from Prism sync kddnewton (Kevin Newton) 11:38 AM Misc #20746: Request to migrate the json gem from flori/json repository to ruby/json +1, as I wrote in https://.com/flori/json/issues/591 I think this is important for many reasons. Eregon (Benoit Daloze) 08:02 AM Misc #20746 (Closed): Request to migrate the json gem from flori/json repository to ruby/json ### Context byroot (Jean Boussier) 11:37 AM Revision fab01b15 (git): [rubygems/rubygems] Remove temporary `.lock` files left around by gem installer https://.com/rubygems/rubygems/commit/edbb2e3475 deivid (David Rodríguez) 11:37 AM Revision 7411caa1 (git): [rubygems/rubygems] Make sure implementations of `Gem.open_file_with_flock` match https://.com/rubygems/rubygems/commit/174a8e5284 deivid (David Rodríguez) 06:51 AM Bug #20745: IO::Buffer#copy triggers UB when src/dest buffers overlap `#set_string` in combination with `.for` with a block has the same problem. hanazuki (Kasumi Hanazuki) 06:33 AM Bug #20745 (Closed): IO::Buffer#copy triggers UB when src/dest buffers overlap The current implementation of `IO::Buffer#copy` uses `memcpy` to copy data between the two memory regions. `memcpy` h... hanazuki (Kasumi Hanazuki) 01:35 AM Feature #20738: Removing a specific entry from a hash literal It would be better to explain the motive. This is an appropriate code. ursm (Keita Urashima) 01:19 AM Feature #20738: Removing a specific entry from a hash literal I would like to offer that as I used a simple grep pattern, I could only find simple examples. I wanted to show that ... ursm (Keita Urashima) 09/15/2024 07:15 PM Bug #20726: Issue with hash without braces when assigned to constant with ractor literals This problem was not reproduced with `--parser=prism`, but with `--parser=parse.y`. osyo (manga osyo) 06:07 PM Bug #20743: ruby doesn't properly split RUBY_DEBUG_LOG_FILTER into items Apparently introduced in the following commit: x-yuri (Yuri Kanivetsky) 05:58 PM Bug #20743 (Assigned): ruby doesn't properly split RUBY_DEBUG_LOG_FILTER into items ``` x-yuri (Yuri Kanivetsky) 06:06 PM Feature #20738: Removing a specific entry from a hash literal > There are several Rails codes that can be improved with this feature. byroot (Jean Boussier) 04:32 PM Feature #20738: Removing a specific entry from a hash literal ursm (Keita Urashima) wrote in #note-9: jeremyevans0 (Jeremy Evans) 12:36 PM Feature #20738: Removing a specific entry from a hash literal Eregon (Benoit Daloze) wrote in #note-8: ursm (Keita Urashima) 05:52 PM Feature #20742: Trying to assign to a variable in statement modifier should emit a warning Assigning in post-conditionals is a fairly common in Ruby. If this is to be a warning, it would have to be limited t... jeremyevans0 (Jeremy Evans) 05:42 PM Feature #20742 (Open): Trying to assign to a variable in statement modifier should emit a warning There is an example in Control Expressions documentation: esad (Esad Hajdarevic) 10:25 AM Bug #20736: prism emits wrong warnings in syntax-error code I think good error recovery is key to have helpful error messages when writing Ruby code. Eregon (Benoit Daloze) 12:51 AM Bug #20736: prism emits wrong warnings in syntax-error code https://.com/ruby/ruby/pull/11626 mame (Yusuke Endoh) 12:46 AM Bug #20736: prism emits wrong warnings in syntax-error code I wonder if error recovery is needed in the interpreter's parser. It might be a benefit to be able to output almost a... mame (Yusuke Endoh) 09:10 AM Bug #20741: RubyVM::InstructionSequence.compile emits a wrong warning (prism?) > prism? byroot (Jean Boussier) 01:05 AM Bug #20741 (Closed): RubyVM::InstructionSequence.compile emits a wrong warning (prism?) ``` mame (Yusuke Endoh) 01:06 AM Revision 532af89e (git): Prevent warnings: the block passed to ... may be ignored mame (Yusuke Endoh) 01:05 AM Revision bc13ec73 (git): Prevent warnings: assigned but unused variable mame (Yusuke Endoh) 09/14/2024 04:34 PM Feature #20738: Removing a specific entry from a hash literal I don't think it's OK to magically drop entries from a literal based on some value, it's way too surprising. Eregon (Benoit Daloze) 05:24 AM Feature #20738: Removing a specific entry from a hash literal I believe that the following two points will prevent the same problems as in the past: ursm (Keita Urashima) 04:53 AM Feature #20738: Removing a specific entry from a hash literal History. Long ago in Ruby, such a special value actually existed. It was `nil`. mame (Yusuke Endoh) 07:54 AM Bug #20730: LoadError if Rakefile has shebang `ruby` command handles a shebang, but it is not a part of the Ruby syntax. nobu (Nobuyoshi Nakada) 09/13/2024 08:58 PM Bug #20736: prism emits wrong warnings in syntax-error code Right now Prism is lexing `9a` as an integer and then an identifier. So it's effectively parsing it as `1; 2; 9; a`. ... kddnewton (Kevin Newton) 07:51 PM Bug #20736: prism emits wrong warnings in syntax-error code Although I can understand the technical reason, I still feel a bit uncomfortable when the warning says “use of a lite... mame (Yusuke Endoh) 05:02 PM Bug #20736 (Feedback): prism emits wrong warnings in syntax-error code kddnewton (Kevin Newton) 03:32 PM Bug #20736: prism emits wrong warnings in syntax-error code This is because Prism recovers from the syntax error. For example: kddnewton (Kevin Newton) 03:23 AM Bug #20736 (Feedback): prism emits wrong warnings in syntax-error code ``` mame (Yusuke Endoh) 07:30 PM Revision ddbd6440 (git): [ruby/prism] Stat file first to check directory https://.com/ruby/prism/commit/4ed7de537b kddnewton (Kevin Newton) 07:16 PM Bug #20473: Ractor array/hash literals Okay, makes sense. Maybe if/when ractors are used more I'll take a look at this again. luke-gru (Luke Gruber) 07:13 PM Revision f85efc97 (git): [ruby/prism] Expose main_script in serialization API https://.com/ruby/prism/commit/0b527ca93f kddnewton (Kevin Newton) 06:13 PM Bug #20735 (Closed): prism emits "ambiguous `&`" warning kddnewton (Kevin Newton) 04:49 PM Bug #20735: prism emits "ambiguous `&`" warning I have opened https://.com/ruby/ruby/pull/11622 to fix this. kddnewton (Kevin Newton) 02:40 AM Bug #20735 (Closed): prism emits "ambiguous `&`" warning ``` mame (Yusuke Endoh) 06:09 PM Bug #20730 (Closed): LoadError if Rakefile has shebang Applied in changeset commit:git|9afc6a981deae6e23d938cf5c2c4baadfeaafdb1. kddnewton (Kevin Newton) 03:23 PM Bug #20730: LoadError if Rakefile has shebang I have opened https://.com/ruby/ruby/pull/11617 to fix this. kddnewton (Kevin Newton) 01:19 AM Bug #20730 (Closed): LoadError if Rakefile has shebang `LoadError` exception will be raised when invoke the rake task with latest ruby 3.4-dev. watson1978 (Shizuo Fujita) 06:09 PM Revision 77521afa (git): [PRISM] Do not warn ambiguous ampersand when symbol literal Fixes [Bug #20735] kddnewton (Kevin Newton) 05:44 PM Feature #20309: Bundled gems for Ruby 3.5 Regarding `irb`, I find it concerning that we need to add code like this: https://.com/ruby/ruby/blob/9afc6a981... deivid (David Rodríguez) 05:16 PM Bug #20737: Accidentally changed warning target on Ruby 3.3 Agreed, I didn't expect new warnings in 3.3.5 when 3.3.4 did not warn, and extra warnings can break CI (e.g. #20713). Eregon (Benoit Daloze) 05:57 AM Bug #20737 (Closed): Accidentally changed warning target on Ruby 3.3 https://.com/ruby/ruby/pull/11613 hsbt (Hiroshi SHIBATA) 04:10 AM Bug #20737: Accidentally changed warning target on Ruby 3.3 Makes sense. Let's revert that back to the Ruby 3.3.4 one in Ruby 3.3.6. k0kubun (Takashi Kokubun) 04:03 AM Bug #20737 (Closed): Accidentally changed warning target on Ruby 3.3 I heard that concern from yhonda. hsbt (Hiroshi SHIBATA) 05:12 PM Misc #20739: Test suite does not carry over CLI options I think it's a real issue and sometimes valuable to fix (it hurts the coverage of tests * flags). Eregon (Benoit Daloze) 01:37 PM Misc #20739 (Open): Test suite does not carry over CLI options I'm not sure if anything needs to change here, but I wanted to report this in case anyone had any particular ideas. W... kddnewton (Kevin Newton) 05:01 PM Bug #20731 (Closed): warning: mismatched indentations at 'when' appears with prism enabled ruby kddnewton (Kevin Newton) 04:08 PM Bug #20731: warning: mismatched indentations at 'when' appears with prism enabled ruby I have opened https://.com/ruby/ruby/pull/11620 to fix this. kddnewton (Kevin Newton) 02:42 AM Bug #20731 (Assigned): warning: mismatched indentations at 'when' appears with prism enabled ruby hsbt (Hiroshi SHIBATA) 01:37 AM Bug #20731: warning: mismatched indentations at 'when' appears with prism enabled ruby @mame hsbt (Hiroshi SHIBATA) 01:34 AM Bug #20731: warning: mismatched indentations at 'when' appears with prism enabled ruby The wrong warning with `rss` gem is a different issue. I have created a separate ticket #20732. mame (Yusuke Endoh) 01:24 AM Bug #20731: warning: mismatched indentations at 'when' appears with prism enabled ruby I also have similar issues with `rss`. hsbt (Hiroshi SHIBATA) 01:20 AM Bug #20731 (Closed): warning: mismatched indentations at 'when' appears with prism enabled ruby ### Steps to reproduce yahonda (Yasuo Honda) 04:51 PM Revision 9afc6a98 (git): [PRISM] Only parse shebang on main script Fixes [Bug #20730] kddnewton (Kevin Newton) 04:51 PM Revision d42d1905 (git): [PRISM] Allow case/when to be indented with no warning Fixes [Bug #20731] kddnewton (Kevin Newton) 04:45 PM Bug #20740: prism_compile coding issue for PM_FORWARDING_SUPER_NODE PR here: https://.com/ruby/ruby/pull/11621 luke-gru (Luke Gruber) 04:44 PM Bug #20740 (Closed): prism_compile coding issue for PM_FORWARDING_SUPER_NODE I found a coding issue in prism_compile.c but I can't find a bug that would result from it. luke-gru (Luke Gruber) 04:09 PM Bug #20732 (Closed): prism emits "mismatched indentations" warning in eval Applied in changeset commit:git|74f315c3f5908512dfdeeab2dd76d93e98149769. kddnewton (Kevin Newton) 03:26 PM Bug #20732: prism emits "mismatched indentations" warning in eval I have opened https://.com/ruby/ruby/pull/11618 to fix this. kddnewton (Kevin Newton) 01:28 AM Bug #20732 (Closed): prism emits "mismatched indentations" warning in eval ```ruby mame (Yusuke Endoh) 04:08 PM Revision 74f315c3 (git): [PRISM] Turn off mismatched indentation warnings in eval Fixes [Bug #20732] kddnewton (Kevin Newton) 03:05 PM Revision 353997dd (git): [ruby/prism] Refactor and move common node flags count into a constant to reuse in templates https://.com/ruby/prism/commit/c20bf05ecc andrykonchin (Andrew Konchin) 03:05 PM Revision 38f8f42e (git): [ruby/prism] Unify code style of flags generation in the nodes templates https://.com/ruby/prism/commit/dbb7e0a44e andrykonchin (Andrew Konchin) 02:58 PM Feature #20738: Removing a specific entry from a hash literal With the previous idea, I can't have both removing entries and returning nil depending on the condition. ursm (Keita Urashima) 01:17 PM Feature #20738: Removing a specific entry from a hash literal nobu (Nobuyoshi Nakada) wrote in #note-1: ursm (Keita Urashima) 12:16 PM Feature #20738: Removing a specific entry from a hash literal Yes, I sometimes do that as well. However, I am not happy that the shape of the resulting hash is unclear. ursm (Keita Urashima) 11:59 AM Feature #20738: Removing a specific entry from a hash literal How about using `**`? osyo (manga osyo) 07:57 AM Feature #20738: Removing a specific entry from a hash literal "A special value" doesn't feel like a good idea to me. nobu (Nobuyoshi Nakada) 07:33 AM Feature #20738 (Rejected): Removing a specific entry from a hash literal Sometimes I want to decide whether or not to add a particular entry to a hash depending on a condition. If the entire... ursm (Keita Urashima) 02:06 PM Revision c996f409 (git): Ignore -Wdangling-pointer in rb_gc_set_stack_end Fixes this compiler warning: peterzhu2118 (Peter Zhu) 01:17 PM Revision f0dcbbe9 (git): [ruby/prism] Reverse-sync numbered reference range handling https://.com/ruby/prism/commit/a2f57ef6e3 kddnewton (Kevin Newton) 12:42 PM Revision 36b2fea6 (git): [rubygems/rubygems] Remove `BUNDLER_IGNORE_DEFAULT_GEM` As long as we use a high enough test version, the default version of deivid (David Rodríguez) 12:42 PM Revision 8e2d971b (git): [rubygems/rubygems] Remove redundant arguments passed to `bundle` helper They are used by default. deivid (David Rodríguez) 12:42 PM Revision 64252851 (git): [rubygems/rubygems] Make sure test does not load system version of Bundler https://.com/rubygems/rubygems/commit/d850ea1d95 deivid (David Rodríguez) 10:37 AM Bug #20725 (Closed): Inconsistent handling of doubly-unbounded ranges in Range#overlap? Applied in changeset commit:git|24493779b79bb57fd2e71bf6e0ababe95448a9d6. nobu (Nobuyoshi Nakada) 01:56 AM Bug #20725: Inconsistent handling of doubly-unbounded ranges in Range#overlap? https://.com/ruby/ruby/pull/11609 nobu (Nobuyoshi Nakada) 09:23 AM Revision 24493779 (git): [Bug #20725] Should not call compare on `nil`-endpoint It means unbounded, always inclusive of other ranges. nobu (Nobuyoshi Nakada) 07:52 AM Revision 0f3dc2f9 (git): Prevent warnings "the block passed to ... may be ignored" mame (Yusuke Endoh) 07:45 AM Bug #20723: `IO#close` is broken on Ruby 3.3+ when using the Fiber scheduler. Sorry about this. I think https://.com/ruby/ruby/pull/11614 is the smallest diff that will fix the issue (and t... kjtsanaktsidis (KJ Tsanaktsidis) 06:49 AM Revision b6c7226f (git): Put typeprof.gemspec mame (Yusuke Endoh) 06:49 AM Revision f090d1fa (git): Try to find bundled gem version from lib/*/version.rb mame (Yusuke Endoh) 06:49 AM Revision cf5b9658 (git): Use the development version of typeprof in test-bundled-gems mame (Yusuke Endoh) 05:35 AM Revision 58942023 (git): typo otherBasis -> orthoBasis The original function name in ao.c was orthoBasis. aoki1980taichi 04:19 AM Revision 3146cbbb (git): Dont't warn reline called from irb, reline is already declared at irb gemspec hsbt (Hiroshi SHIBATA) 02:39 AM Revision 6ae05584 (git): [ruby/net-http] Prevent warnings ``` mame (Yusuke Endoh) 02:34 AM Revision 5e3f1b6a (git): Prevent a warning: assigned but unused variable - exp_events mame (Yusuke Endoh) 02:32 AM Revision d1d0c50c (git): Prevent a warning: assigned but unused variable - t0 mame (Yusuke Endoh) 02:30 AM Bug #20734 (Closed): Test failure at FreeBSD 14.1 FreeBSD 14.1 build is also failure with ruby master. This is different error from #20733 hsbt (Hiroshi SHIBATA) 02:29 AM Bug #20733 (Open): Build failure OpenSSL extension with FreeBSD 13.3 FreeBSD 13.3 build on Ruby CI was failure from 1 week ago. I manually build ruby master on FreeBSD 13 and got the fol... hsbt (Hiroshi SHIBATA) 01:39 AM Misc #20728: Propose Eileen Uchitelle as a core committer I thought she was a committer long ago. mame (Yusuke Endoh) 12:47 AM Bug #20729 (Closed): Test failure with 0fc8422a05 and native mswin environment I got the following failure with mswin environment. hsbt (Hiroshi SHIBATA) 12:28 AM Revision d80a81c1 (git): Constify `struct getpwnam_r_args::login` nobu (Nobuyoshi Nakada) Also available in: Atom
11:43 PM Bug #20734 (Closed): Test failure at FreeBSD 14.1
10:53 PM Feature #20756 (Rejected): Introduce Boolean class
09:50 PM Feature #20756 (Rejected): Introduce Boolean class
06:51 PM Revision 2230ac4a (git): Fix potentially missing write barrier in iseq_build_kw
05:14 PM Revision dc644482 (git): Remove an unused variable
03:28 PM Misc #20728: Propose Eileen Uchitelle as a core committer
02:34 PM Bug #20716 (Closed): Different instance_method behavior in Ruby 2.7 and Ruby 3.x
09:08 AM Revision dc8c3822 (git): Fix bug at fork on FreeBSD
04:42 PM Bug #20740 (Closed): prism_compile coding issue for PM_FORWARDING_SUPER_NODE
04:42 PM Revision 461c4896 (git): [rubygems/rubygems] Add a note about when hack can be removed
03:52 PM Revision 96da3f16 (git): [ruby/prism] Allow returns in default parameter values
01:29 PM Bug #20755 (Closed): IO::Buffer#transfer transfers mutable reference to String's memory but not lock ownership
12:14 PM Bug #20754: [doc] `Hash::new` is missing from rdoc for 3.4
12:02 PM Misc #20717: DevMeeting-2024-10-03
11:48 AM Bug #20745: IO::Buffer#copy triggers UB when src/dest buffers overlap
06:30 AM Feature #20309: Bundled gems for Ruby 3.5
02:16 AM Revision 4797b070 (git): Prevent a warning (retry)
11:49 PM Bug #20751 (Closed): Regression in Prism related to use of return in default argument values
06:12 AM Revision d81b0588 (git): [ruby/strscan] Accept String as a pattern at non head
03:52 AM Revision bb2d2473 (git): [DOC] Fix autoload method formatting
12:11 AM Bug #20723 (Closed): `IO#close` is broken on Ruby 3.3+ when using the Fiber scheduler.
07:07 AM Bug #20744: syntax error found (SyntaxError) `UTF-8 mixed within US-ASCII source` reported Ruby with Prism parser
04:33 AM Bug #20744 (Closed): syntax error found (SyntaxError) `UTF-8 mixed within US-ASCII source` reported Ruby with Prism parser
05:36 PM Revision 6c4ce726 (git): [ruby/irb] Use InstructionSequence#script_lines to get method source
04:33 PM Revision 1c3981cb (git): [DOC] Tweaks for Array#select!
04:14 PM Misc #20717: DevMeeting-2024-10-03
01:35 AM Feature #20738: Removing a specific entry from a hash literal
07:15 PM Bug #20726: Issue with hash without braces when assigned to constant with ractor literals
06:07 PM Bug #20743: ruby doesn't properly split RUBY_DEBUG_LOG_FILTER into items
05:42 PM Feature #20742 (Open): Trying to assign to a variable in statement modifier should emit a warning
01:19 AM Bug #20730 (Closed): LoadError if Rakefile has shebang
03:05 PM Revision 353997dd (git): [ruby/prism] Refactor and move common node flags count into a constant to reuse in templates