Age | Commit message (Collapse) | Author |
---|
| Notes: Merged: https://.com/ruby/ruby/pull/13275 |
| Notes: Merged: https://.com/ruby/ruby/pull/13275 |
| |
| |
| https://.com/rubygems/rubygems/commit/e4f70a3e4f |
| https://.com/rubygems/rubygems/commit/40cf54d256 |
| https://.com/rubygems/rubygems/commit/38a0bdc123 |
| https://.com/rubygems/rubygems/commit/bf63859e1e |
| https://.com/rubygems/rubygems/commit/0aae094c89 |
| https://.com/rubygems/rubygems/commit/e6aa8aabcd |
| - The command can either be run using: 1. `bundle doctor --ssl` 2. `bundle doctor ssl` The later is most useful when you need to specify custom ssl options (such as the verify mode or the TLS version when running the diagnostic). The implementation will follow in the next commits. https://.com/rubygems/rubygems/commit/993d12874c |
| - See explanation in previous commit https://.com/rubygems/rubygems/commit/170890befb4c https://.com/rubygems/rubygems/commit/8f1b5a4479 |
| - Adding a new `ssl` option to bundle doctor will make the `Doctor` command quite bloated. The "diagnose ssl" option will also have children option to allow passing which host or which tls version you want to diagnose and I feel these options don't belong in the doctor command. So my intention in this commit is to prepare to have a new `Doctor` subcommand and allow for better organisation of the code: The command will be: `bundle doctor` -> Run exactly the same as before. `bundle doctor --ssl` -> Run the doctor command and diagnose SSL with default options (rubygems.org as the host and verify peer as the verify mode) `bundle doctor ssl --host .com` -> Run the ssl subcommand and pass a specific host. This commit just renames a file in order to avoid big diff chunks. |
| platforms https://.com/rubygems/rubygems/commit/c39d2f84fd |
| incompatible https://.com/rubygems/rubygems/commit/282e4a8593 |
| It handles resolution packages but also other stuff. https://.com/rubygems/rubygems/commit/4baec92c20 |
| https://.com/rubygems/rubygems/commit/ed31e888fd |
| https://.com/rubygems/rubygems/commit/42534e746b |
| If we materialized to a different platform, then the dependencies may actually be different so the validation does not really make sense. https://.com/rubygems/rubygems/commit/68fad98e6f |
| https://.com/rubygems/rubygems/commit/4b6f07f634 |
| In frozen mode, the previous logic would not set the platform locked originally in the materialized specification, and that would trigger the warning about insecure materialization incorrectly. https://.com/rubygems/rubygems/commit/a18001e10c |
| Don't mention "Found changes from the lockfile" because that's not really true in general. https://.com/rubygems/rubygems/commit/0181c278e8 |
| If both a native and a generic version are locked, but the native version is incompatible with the running Ruby, Bundler will still keep the native version in the lockfile, since it could be potentially useful when using other rubies. However, when `bundle update` is run, this was not the case because the locked native gems were not using the right source when materializing. They were using the lockfile source instead of the Gemfile source, and that meant they could not be found when materializing, because the lockfile source always uses local mode so does not see them. The effect of this was normally that they were incorrectly removed from the lockfile and a strange "this spec has been possibly yanked" was printed in verbose mode. However, in certain situations (i.e., when the generic gem would bring extra dependencies), it could also make `bundle update` crash. The solution is, when adding this extra locked specs to the result after resolving, maybe sure they inherit the source from the resolved specs, so they can be found when materializing. `bundle install` did not have the issue because it passes locked specs to the resolver, and assigns the right source to them in `Definition#converge_locked_specs`. https://.com/rubygems/rubygems/commit/91ce881fda |
| `Definition#specs` does the same thing but memoizes the result. https://.com/rubygems/rubygems/commit/b62bf9fe41 |
| https://.com/rubygems/rubygems/commit/458fa5dc4c |
| * Explicitly recommend copying full command output and not just the bug report template part. * Include quadruple quotes in the "What actually happened section" and tell users to copy full command output inside. Hopefully quadruple quotes will make the error report information (which includes triple quotes itself) render fine by default. * Avoid "actually" as per quality_spec.rb recommendation. https://.com/rubygems/rubygems/commit/0a3bf2edb1 |
| mutable dependencies array That restores support for compact index dummy implementations that only lists versions, without checksums or dependencies. This format is undocumented, so we may want to get rid of it in the future. However, some of our tests rely on it, and some implementations did use it (gems.mutant.dev at least). And the way the code was written suggest that support was intentional. So for now, we should restore it. https://.com/rubygems/rubygems/commit/0427d8c983 |
| It's available in RubyGems since 3.2.3 and we no longer support that old version. |
| have changed Since we will now add it back if the final resolution is compatible, we can also get this kind of edge case (`bundle add`) working. https://.com/rubygems/rubygems/commit/cdc5ebec77 |
| Instead, remove them anytime we find dependencies don't match the lockfile for a platform, and then add them back after resolution if they ended up being valid. https://.com/rubygems/rubygems/commit/220bd77887 |
| anything https://.com/rubygems/rubygems/commit/9fd92ade54 |
| I don't like traversing the array and modifying it at the same time while it seems to work. https://.com/rubygems/rubygems/commit/6551c74c27 |
| https://.com/rubygems/rubygems/commit/33c3caa63f |
| https://.com/rubygems/rubygems/commit/01a14a7073 |
| My application spends more than 30% of time during `bundle update` comparing versions due to versions being sorted inside next_package_to_try. This has been addressed in pub_grub by defining a strategy interface (a `#next_package_and_version` method) which allows consumers to have finer control over the heuristic to select the next package to try. This commit implements the new strategy interface to remove extraneous version sorting (previously in next_package_to_try) since only the final count of versions is used. Combined with a previous change to pub_grub (already applied to Bundler), this commit results in `bundle update` taking only half the time it did on 2.6.5. https://.com/rubygems/rubygems/commit/62f69e27f0 |
| https://.com/rubygems/rubygems/commit/a0f7851451 |
| https://.com/rubygems/rubygems/commit/4497555023 |
| missing https://.com/rubygems/rubygems/commit/054a0cd76c Notes: Merged: https://.com/ruby/ruby/pull/12968 |
| It's a dependency, not a specification. https://.com/rubygems/rubygems/commit/9d78f5aa14 Notes: Merged: https://.com/ruby/ruby/pull/12968 |
| with checksums https://.com/rubygems/rubygems/commit/8e2c5748d9 Notes: Merged: https://.com/ruby/ruby/pull/12968 |
| Instead of doing an explicit pass, let sources be replaced while checking if specifications are up to date. https://.com/rubygems/rubygems/commit/676271e804 Notes: Merged: https://.com/ruby/ruby/pull/12968 |
| Instead of doing an explicit pass to preserve the source from the Gemfile when it's a `Source::Gemspec`, add a special case to our generic source replacement method. https://.com/rubygems/rubygems/commit/20c8c42380 Notes: Merged: https://.com/ruby/ruby/pull/12968 |
| sources The `converge_dependencies` method already replaces the source of the dependency with an equivalent source from the Gemfile if possible. https://.com/rubygems/rubygems/commit/a449e7ba19 Notes: Merged: https://.com/ruby/ruby/pull/12968 |
| https://.com/rubygems/rubygems/commit/58e9bd9962 Notes: Merged: https://.com/ruby/ruby/pull/12968 |
| https://.com/rubygems/rubygems/commit/4c05ac8306 Notes: Merged: https://.com/ruby/ruby/pull/12968 |
| https://.com/rubygems/rubygems/commit/24523a839e Notes: Merged: https://.com/ruby/ruby/pull/12968 |
| https://.com/rubygems/rubygems/commit/9c6b57c01d Notes: Merged: https://.com/ruby/ruby/pull/12968 |
| https://.com/rubygems/rubygems/commit/e9f4d1e5c2 Notes: Merged: https://.com/ruby/ruby/pull/12968 |
| https://.com/rubygems/rubygems/commit/7026b5f2e5 Notes: Merged: https://.com/ruby/ruby/pull/12968 |
| https://.com/rubygems/rubygems/commit/4e66fe4208 Notes: Merged: https://.com/ruby/ruby/pull/12968 |