@@ -1700,7 +1700,7 @@ or refactoring an existing one.
|
1700 | 1700 |
|
1701 | 1701 | **Bad:**
|
1702 | 1702 | ```javascript
|
1703 |
| -const assert = require('assert'); |
| 1703 | +import assert from 'assert'; |
1704 | 1704 |
|
1705 | 1705 | describe('MakeMomentJSGreatAgain', () => {
|
1706 | 1706 | it('handles date boundaries', () => {
|
@@ -1723,7 +1723,7 @@ describe('MakeMomentJSGreatAgain', () => {
|
1723 | 1723 |
|
1724 | 1724 | **Good:**
|
1725 | 1725 | ```javascript
|
1726 |
| -const assert = require('assert'); |
| 1726 | +import assert from 'assert'; |
1727 | 1727 |
|
1728 | 1728 | describe('MakeMomentJSGreatAgain', () => {
|
1729 | 1729 | it('handles 30-day months', () => {
|
@@ -1754,11 +1754,14 @@ Promises are a built-in global type. Use them!
|
1754 | 1754 |
|
1755 | 1755 | **Bad:**
|
1756 | 1756 | ```javascript
|
1757 |
| -require('request').get('https://en.wikipedia.org/wiki/Robert_Cecil_Martin', (requestErr, response) => { |
| 1757 | +import { get } from 'request'; |
| 1758 | +import { writeFile } from 'fs'; |
| 1759 | + |
| 1760 | +get('https://en.wikipedia.org/wiki/Robert_Cecil_Martin', (requestErr, response) => { |
1758 | 1761 | if (requestErr) {
|
1759 | 1762 | console.error(requestErr);
|
1760 | 1763 | } else {
|
1761 |
| -require('fs').writeFile('article.html', response.body, (writeErr) => { |
| 1764 | +writeFile('article.html', response.body, (writeErr) => { |
1762 | 1765 | if (writeErr) {
|
1763 | 1766 | console.error(writeErr);
|
1764 | 1767 | } else {
|
@@ -1772,9 +1775,12 @@ require('request').get('https://en.wikipedia.org/wiki/Robert_Cecil_Martin', (req
|
1772 | 1775 |
|
1773 | 1776 | **Good:**
|
1774 | 1777 | ```javascript
|
1775 |
| -require('request-promise').get('https://en.wikipedia.org/wiki/Robert_Cecil_Martin') |
| 1778 | +import { get } from 'request'; |
| 1779 | +import { writeFile } from 'fs'; |
| 1780 | + |
| 1781 | +get('https://en.wikipedia.org/wiki/Robert_Cecil_Martin') |
1776 | 1782 | .then((response) => {
|
1777 |
| -return require('fs-promise').writeFile('article.html', response); |
| 1783 | +return writeFile('article.html', response); |
1778 | 1784 | })
|
1779 | 1785 | .then(() => {
|
1780 | 1786 | console.log('File written');
|
@@ -1795,9 +1801,12 @@ today!
|
1795 | 1801 |
|
1796 | 1802 | **Bad:**
|
1797 | 1803 | ```javascript
|
1798 |
| -require('request-promise').get('https://en.wikipedia.org/wiki/Robert_Cecil_Martin') |
| 1804 | +import { get } from 'request-promise'; |
| 1805 | +import { writeFile } from 'fs-promise'; |
| 1806 | + |
| 1807 | +get('https://en.wikipedia.org/wiki/Robert_Cecil_Martin') |
1799 | 1808 | .then((response) => {
|
1800 |
| -return require('fs-promise').writeFile('article.html', response); |
| 1809 | +return writeFile('article.html', response); |
1801 | 1810 | })
|
1802 | 1811 | .then(() => {
|
1803 | 1812 | console.log('File written');
|
@@ -1810,10 +1819,13 @@ require('request-promise').get('https://en.wikipedia.org/wiki/Robert_Cecil_Marti
|
1810 | 1819 |
|
1811 | 1820 | **Good:**
|
1812 | 1821 | ```javascript
|
| 1822 | +import { get } from 'request-promise'; |
| 1823 | +import { writeFile } from 'fs-promise'; |
| 1824 | + |
1813 | 1825 | async function getCleanCodeArticle() {
|
1814 | 1826 | try {
|
1815 |
| -const response = await require('request-promise').get('https://en.wikipedia.org/wiki/Robert_Cecil_Martin'); |
1816 |
| -await require('fs-promise').writeFile('article.html', response); |
| 1827 | +const response = await get('https://en.wikipedia.org/wiki/Robert_Cecil_Martin'); |
| 1828 | +await writeFile('article.html', response); |
1817 | 1829 | console.log('File written');
|
1818 | 1830 | } catch(err) {
|
1819 | 1831 | console.error(err);
|
|
0 commit comments