Conversation

alixhami

No description provided.

@alixhamialixhami added the api: bigqueryIssues related to the BigQuery API.label Nov 6, 2017
@googlebotgooglebot added the cla: yesThis human has signed the Contributor License Agreement.label Nov 6, 2017
@theacodestheacodes requested a review from tswast November 6, 2017 18:54
@theacodes

I'd like @tswast or @jba to take a look from a BigQuery perspective as well.

@jba

LGTM, but I will defer to Tim.

@alixhamialixhami mentioned this pull request Nov 7, 2017
Merged
tswast
tswast approved these changes Nov 10, 2017
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

I wonder if this change makes Client.query_rows() unnecessary?

@alixhami

@tswast If the purpose of Client.query_rows() was just to get query results without calling result(), then it would be unnecessary. Are there other uses for it, or should I remove it in another PR?

@alixhamialixhami merged commit d3999a8 into googleapis:master Nov 13, 2017
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Nov 13, 2017
@dhermes
Post googleapis#4350 cleanup.
17c721a
This happened because googleapis#4350 was sent before googleapis#4355 was merged.
@dhermesdhermes mentioned this pull request Nov 13, 2017
Merged
dhermes added a commit that referenced this pull request Nov 13, 2017
@dhermes
Post #4350 cleanup. (#4389)
db216c0
This happened because #4350 was sent before #4355 was merged.
@tswast

Talked in person. Let's remove query_rows in another PR. I can think of no other uses for it.

chemelnucfin pushed a commit to chemelnucfin/google-cloud-python that referenced this pull request Nov 15, 2017
@alixhami
BigQuery: Can iterate over QueryJob results without explicitly callin…
3b8f557
…g result() (googleapis#4350)
chemelnucfin pushed a commit to chemelnucfin/google-cloud-python that referenced this pull request Nov 15, 2017
@dhermes
Post googleapis#4350 cleanup. (googleapis#4389)
9a407f5
This happened because googleapis#4350 was sent before googleapis#4355 was merged.
chemelnucfin pushed a commit to chemelnucfin/google-cloud-python that referenced this pull request Nov 15, 2017
@alixhami
BigQuery: Can iterate over QueryJob results without explicitly callin…
341549d
…g result() (googleapis#4350)
chemelnucfin pushed a commit to chemelnucfin/google-cloud-python that referenced this pull request Nov 15, 2017
@dhermes
Post googleapis#4350 cleanup. (googleapis#4389)
1a5cfa4
This happened because googleapis#4350 was sent before googleapis#4355 was merged.
@alixhamialixhami deleted the bq-queryjob-iter branch November 16, 2017 20:12
@alixhamialixhami mentioned this pull request Nov 21, 2017
Merged
@tseavertseaver mentioned this pull request Jan 4, 2018
Merged
parthea pushed a commit that referenced this pull request Oct 21, 2023
@busunkim96
testing(automl): retry upon InternalServerError [(#4350)](GoogleCloud…
4b8e11b
…Platform/python-docs-samples#4350)

fixes #4343
Sign up for free to join this conversation on . Already have an account? Sign in to comment

@tswast tswast tswast approved these changes

@theacodes theacodes theacodes approved these changes

@dhermes dhermes Awaiting requested review from dhermes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

No one assigned
api: bigqueryIssues related to the BigQuery API.cla: yesThis human has signed the Contributor License Agreement.
None yet
No milestone

Successfully merging this pull request may close these issues.