Conversation

tswast

insert_rows aligns better with API request (Tabledata.insertAll). Feedback from BQ GA review.

Note that the create_rows() sample in the Python migration guide already points to a commit hash, so this should be safe to merge whenever.

`insert_rows` aligns better with API request (Tabledata.insertAll).
Feedback from BQ GA review.
@googlebotgooglebot added the cla: yesThis human has signed the Contributor License Agreement.label Dec 22, 2017
@tseavertseaver added the api: bigqueryIssues related to the BigQuery API.label Jan 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tswasttswast merged commit 55df6a2 into googleapis:master Jan 2, 2018
@tswasttswast deleted the bq-insert-rows branch January 2, 2018 19:15
body, table, job_config=job_config).result()

df = Config.CLIENT.list_rows(
table, selected_fields=schema).to_dataframe()

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

to_delete.insert(0, table_ref)
# Load a table using a local JSON file from memory.
client.load_table_from_file(
body, table_ref, job_config=job_config).result()

This comment was marked as spam.

@tseavertseaver mentioned this pull request Jan 4, 2018
Sign up for free to join this conversation on . Already have an account? Sign in to comment
api: bigqueryIssues related to the BigQuery API.cla: yesThis human has signed the Contributor License Agreement.
None yet

Successfully merging this pull request may close these issues.