Conversation

elizabethdinella

Issue: #25082
Open bugs: #26374, #26375, #26376

clone = node && getSynthesizedDeepCloneWorker(node as NonNullable<T>, renameMap, checker, callback);
}

if (clone && !includeTrivia) suppressLeadingAndTrailingTrivia(clone);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clone [](start = 12, length = 5)

If clone can be undefined, the next if should check it too.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The merge looks good. It would be cool if there were TODOs with bug numbers in the code, but just listing them in the PR would be helpful enough.

@elizabethdinellaelizabethdinella merged commit 421730a into microsoft:master Aug 10, 2018
Sign up for free to join this conversation on . Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.