Conversation

weswigham

Fixes #18865

return extendedConfigPath;
}
// If the path isn't a rooted or relative path, resolve like a module
const resolved = nodeModuleNameResolver(extendedConfig, combinePaths(basePath, "tsconfig.json"), { moduleResolution: ModuleResolutionKind.NodeJs }, host, /*cache*/ undefined, /*lookupConfig*/ true);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no way to traceResolution this. Ideally we would want to flow that option here (esp when invoked from command prompt)? To ensure users are able to find out whats going on when resolving tsconfig.json?

@weswighamweswigham added this to the TypeScript 3.2 milestone Oct 5, 2018
@weswigham

Ping @sheetalkamat I wired through tracing; anything else?

@weswighamweswigham merged commit 05716a7 into microsoft:master Oct 25, 2018
@weswighamweswigham deleted the config-inheritance-through-modules branch October 25, 2018 17:20
@mightyiam

I'm thrilled. Where can I see the documentation for this, please?

@kristianmandrup

Awesome! Hope to see this in the next release!!! :D

Sign up for free to join this conversation on . Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.