Angular 19 support

[servefast-cto]

Title says it all :)

[google-oss-bot]

This issue does not seem to follow the issue template. Make sure you provide all the required information.

[Ruisi-Lu]

The RC version supporting Angular 19 was already released yesterday.
https://www.npmjs.com/package/@angular/fire/v/19.0.0-rc.0

[StefanKern]

Are there any issues with it? I saw angular 18 was released then basically the same day, so I am wondering when it will ship :)

and thank you for all the great work you are doing :)

[mvergarair]

I upgraded and got this issue: #3580

[quedicesebas]

I'm getting this:

npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: @angular/fire@1[8](https://.com/esaesin/lacomanda-app/actions/runs/11958329749/job/33337612327#step:4:9).0.1
npm error Found: @angular/common@1[9](https://.com/esaesin/lacomanda-app/actions/runs/11958329749/job/33337612327#step:4:10).0.0
npm error node_modules/@angular/common
npm error   @angular/common@"^19.0.0" from the root project
npm error   peer @angular/common@"^18.0.0 || ^19.0.0" from @angular/cdk@18.2.4
npm error   node_modules/@angular/cdk
npm error     @angular/cdk@"^18.2.4" from the root project
npm error   7 more (@angular/forms, @angular/platform-browser, ...)
npm error
npm error Could not resolve dependency:
npm error peer @angular/common@"^18.0.0" from @angular/fire@18.0.1
npm error node_modules/@angular/fire
npm error   @angular/fire@"^18.0.1" from the root project
npm error   peer @angular/fire@"^18.0.1" from @esaesin/lacomanda-firebase@4.3.0
npm error   node_modules/@esaesin/lacomanda-firebase
npm error     @esaesin/lacomanda-firebase@"^4.3.0" from the root project
npm error
npm error Conflicting peer dependency: @angular/common@18.2.[12](https://.com/esaesin/lacomanda-app/actions/runs/11958329749/job/33337612327#step:4:13)
npm error node_modules/@angular/common
npm error   peer @angular/common@"^18.0.0" from @angular/fire@18.0.1
npm error   node_modules/@angular/fire
npm error     @angular/fire@"^18.0.1" from the root project
npm error     peer @angular/fire@"^18.0.1" from @esaesin/lacomanda-firebase@4.3.0
npm error     node_modules/@esaesin/lacomanda-firebase
npm error       @esaesin/lacomanda-firebase@"^4.3.0" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.

Can I deploy an app updated to Angular 19 with any workaround?

[Ruisi-Lu]

I'm getting this:

npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: @angular/fire@1[8](https://.com/esaesin/lacomanda-app/actions/runs/11958329749/job/33337612327#step:4:9).0.1
npm error Found: @angular/common@1[9](https://.com/esaesin/lacomanda-app/actions/runs/11958329749/job/33337612327#step:4:10).0.0
npm error node_modules/@angular/common
npm error   @angular/common@"^19.0.0" from the root project
npm error   peer @angular/common@"^18.0.0 || ^19.0.0" from @angular/cdk@18.2.4
npm error   node_modules/@angular/cdk
npm error     @angular/cdk@"^18.2.4" from the root project
npm error   7 more (@angular/forms, @angular/platform-browser, ...)
npm error
npm error Could not resolve dependency:
npm error peer @angular/common@"^18.0.0" from @angular/fire@18.0.1
npm error node_modules/@angular/fire
npm error   @angular/fire@"^18.0.1" from the root project
npm error   peer @angular/fire@"^18.0.1" from @esaesin/lacomanda-firebase@4.3.0
npm error   node_modules/@esaesin/lacomanda-firebase
npm error     @esaesin/lacomanda-firebase@"^4.3.0" from the root project
npm error
npm error Conflicting peer dependency: @angular/common@18.2.[12](https://.com/esaesin/lacomanda-app/actions/runs/11958329749/job/33337612327#step:4:13)
npm error node_modules/@angular/common
npm error   peer @angular/common@"^18.0.0" from @angular/fire@18.0.1
npm error   node_modules/@angular/fire
npm error     @angular/fire@"^18.0.1" from the root project
npm error     peer @angular/fire@"^18.0.1" from @esaesin/lacomanda-firebase@4.3.0
npm error     node_modules/@esaesin/lacomanda-firebase
npm error       @esaesin/lacomanda-firebase@"^4.3.0" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.

Can I deploy an app updated to Angular 19 with any workaround?

If you wish to use the RC version, you should update it manually.

[quedicesebas]

How can we help to release the 19 version sooner?

[quedicesebas]

The RC version supporting Angular 19 was already released yesterday. https://www.npmjs.com/package/@angular/fire/v/19.0.0-rc.0

what change in the API? I'm getting this errors after upgrading:

FirebaseError: Expected type '_Query', but it was: a custom _DocumentReference object

and

FirebaseError: Type does not match the expected instance. Did you pass a reference from a different Firestore SDK?

[quedicesebas]

The RC version supporting Angular 19 was already released yesterday. https://www.npmjs.com/package/@angular/fire/v/19.0.0-rc.0

what change in the API? I'm getting this errors after upgrading:

FirebaseError: Expected type '_Query', but it was: a custom _DocumentReference object

and

FirebaseError: Type does not match the expected instance. Did you pass a reference from a different Firestore SDK?

Adding firebase as dependency in my project resolves the problem (it was originated by the dependency rxfire library).

[Char2sGu]

Add the following to your package.json overrides solves it:

    "@angular/fire": {
      "@angular/core": "$@angular/core",
      "@angular/common": "$@angular/common",
      "@angular/platform-browser": "$@angular/platform-browser",
      "@angular/platform-browser-dynamic": "$@angular/platform-browser-dynamic"
    },

[Char2sGu]

But, honestly, why depend on a specific major release of Angular? >=18 seems to be a much better choice that can be compatible with any future releases while requiring a minimum version

[juane1000]

Add the following to your package.json overrides solves it:

"@angular/fire": {
  "@angular/core": "$@angular/core",
  "@angular/common": "$@angular/common",
  "@angular/platform-browser": "$@angular/platform-browser",
  "@angular/platform-browser-dynamic": "$@angular/platform-browser-dynamic"
},

Recommend deleting your node_modules with this workaround. Simply adding it and reinstalling didn't work.

[miapppro]

Hasta cuando esperaremos..

Global setting: enabled
Local setting: enabled
Effective status: enabled
√ Determining Package Manager
› Using package manager: npm
√ Searching for compatible package version
› Unable to find compatible package. Using 'latest' tag.
√ Loading package information from registry
› ‼ Package has unmet peer dependencies. Adding the package may not succeed.
√ Confirming installation
× Unable to install package

npm ERR!
code ERESOLVE
npm
ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: firebase-pro@0.0.0
npm
ERR! Found: @angular/common@19.0.0
npm ERR! node_modules/@angular/common
npm
ERR! @angular/common@"^19.0.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm
ERR! peer @angular/common@"^18.0.0" from @angular/fire@18.0.1
npm ERR! node_modules/@angular/fire
npm ERR!
@angular/fire@"18.0.1" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm
ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm
ERR!
npm ERR!
npm
ERR! For a full report see:
npm ERR!
C:\Users\Administracion\AppData\Local\npm-cache_logs\2024-11-26T14_08_58_245Z-eresolve-report.txt
npm ERR!
A complete log of this run can be found in: C:\Users\Administracion\AppData\Local\npm-cache_logs\2024-11-26T14_08_58_245Z-debug-0.log

[bashoogzaad]

For me it works just fine! (@angular/fire 19.0.0-rc.0 and firebase 11.0.2). I need to install with --legacy-peer-deps but then it works.

[quedicesebas]

For me it works just fine! (@angular/fire 19.0.0-rc.0 and firebase 11.0.2). I need to install with --legacy-peer-deps but then it works.

That's not working fine, because in a firebase App Hosting pipeline it's going to fail.