bug symfony#3934 Move __construct after the repository assignment (cmodijk)

weaverryan · weaverryan · commit 04f43183dea6 · 2014-06-11T10:36:43.000-05:00
This PR was submitted for the 2.5 branch but it was merged into the 2.4 branch instead (closes symfony#3934). Discussion ---------- Move __construct after the repository assignment The configure function is called from the parent::__construct(); so the $this->nameRepository is still empty during the configure. Thats why it should be the other way around. Commits ------- f06e49c Move __construct after the repository assignment
diff --git a/cookbook/console/commands_as_services.rst b/cookbook/console/commands_as_services.rst
@@ -90,9 +90,9 @@ have some ``NameRepository`` service that you'll use to get your default value::
 
         public function __construct(NameRepository $nameRepository)
         {
-            parent::__construct();
-            
             $this->nameRepository = $nameRepository;
+            
+            parent::__construct();
         }
 
         protected function configure()

Original file line number	Diff line number	Diff line change
@@ -90,9 +90,9 @@ have some ``NameRepository`` service that you'll use to get your default value::
`90`	`90`
`91`	`91`	`public function __construct(NameRepository $nameRepository)`
`92`	`92`	`{`
`93`		`-parent::__construct();`
`94`		`-`
`95`	`93`	`$this->nameRepository = $nameRepository;`
	`94`	`+`
	`95`	`+parent::__construct();`
`96`	`96`	`}`
`97`	`97`
`98`	`98`	`protected function configure()`