This repository was archived by the owner on Dec 3, 2023. It is now read-only.

Conversation

codyoss

Fixes #123

@codyosscodyoss requested a review from chingor13 January 9, 2020 20:01
@googlebotgooglebot added the cla: yesThis human has signed the Contributor License Agreement.label Jan 9, 2020
@codecov

Codecov Report

Merging #124 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #124      +/-   ##
============================================
- Coverage     66.32%   66.27%   -0.06%     
- Complexity      365      370       +5     
============================================
  Files            34       34              
  Lines          1877     1877              
  Branches        240      240              
============================================
- Hits           1245     1244       -1     
- Misses          530      531       +1     
  Partials        102      102
Impacted FilesCoverage ΔComplexity Δ
...src/main/java/com/google/cloud/ServiceOptions.java43.47% <100%> (-0.4%)33 <0> (+1)
.../java/com/google/cloud/testing/CommandWrapper.java87.87% <0%> (-9.1%)13% <0%> (ø)
...a/com/google/cloud/testing/BaseEmulatorHelper.java31.42% <0%> (+0.57%)5% <0%> (ø)⬇️
.../com/google/cloud/MonitoredResourceDescriptor.java84.03% <0%> (+1.68%)24% <0%> (+4%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01cbf1e...9fcb2ff. Read the comment docs.

Sign up for free to subscribe to this conversation on . Already have an account? Sign in.
cla: yesThis human has signed the Contributor License Agreement.
None yet

Successfully merging this pull request may close these issues.

Core: ServiceOptions.setCredentials fails with ClassCastException when using UserCredentials