Conversation

tswast

This shouldn't be necessary, as sqlglot is only used as a transitive dependency through ibis-framework, but in setting the constraints, we can have greater assurance that sqlglot is upgraded alongside bigframes in existing environments.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #315 🦕

This shouldn't be necessary, as sqlglot is only used as a transitive
dependency through ibis-framework, but in setting the constraints, we
can have greater assurance that sqlglot is upgraded alongside bigframes
in existing environments.
@tswasttswast requested review from a team as code owners February 23, 2024 17:22
@tswasttswast requested a review from junyazhang February 23, 2024 17:22
@product-auto-labelproduct-auto-label bot added size: mPull request size is medium.api: bigqueryIssues related to the googleapis/python-bigquery-dataframes API.labels Feb 23, 2024
@tswast

prerelease failures appear to be due to new pandas release pandas==2.2.1. We need to fix our tests for pandas 2.2.x still (internal issue b/322845272)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tswasttswast merged commit 8b62d77 into main Feb 23, 2024
@tswasttswast deleted the issue315-sqlglot branch February 23, 2024 19:20
@release-pleaserelease-please bot mentioned this pull request Feb 21, 2024
Sign up for free to join this conversation on . Already have an account? Sign in to comment
api: bigqueryIssues related to the googleapis/python-bigquery-dataframes API.size: mPull request size is medium.
None yet

Successfully merging this pull request may close these issues.

sqlglot.errors.ParseError for sample from website