Conversation

Linchin
  • _range_to_json() conversion function to use insertAll
  • unit tests for the conversion functions
  • supports client.insert_rows() with dictionary and tuple, in the form of a dictionary or string literal
  • adds client.insert_rows() unit tests for each case we do not test for inserting different data types here
  • client.insert_row_from_dataframe() just works

Fixes #<issue_number_goes_here> 🦕

@LinchinLinchin requested review from a team as code owners May 2, 2024 22:09
@LinchinLinchin requested a review from leahecole May 2, 2024 22:09
@product-auto-labelproduct-auto-label bot added the size: mPull request size is medium.label May 2, 2024
@product-auto-labelproduct-auto-label bot added the api: bigqueryIssues related to the googleapis/python-bigquery API.label May 2, 2024
@LinchinLinchin removed the request for review from leahecole May 2, 2024 22:12
@LinchinLinchin added the do not mergeIndicates a pull request not ready for merge, due to either quality or timing.label May 2, 2024
@LinchinLinchin assigned shollyman and unassigned mrfaizal May 2, 2024
alvarowolfx
alvarowolfx approved these changes May 3, 2024
View reviewed changes
@LinchinLinchin removed the do not mergeIndicates a pull request not ready for merge, due to either quality or timing.label May 3, 2024
@LinchinLinchin merged commit 74e75e8 into googleapis:main May 6, 2024
@release-pleaserelease-please bot mentioned this pull request May 6, 2024
Merged
@LinchinLinchin mentioned this pull request May 10, 2024
Closed
6 tasks
This was referencedMay 21, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on . Already have an account? Sign in to comment

@alvarowolfx alvarowolfx alvarowolfx approved these changes

@PhongChuong PhongChuong Awaiting requested review from PhongChuong

@shollyman shollyman Awaiting requested review from shollyman

@shollyman shollyman

api: bigqueryIssues related to the googleapis/python-bigquery API.size: mPull request size is medium.
None yet
No milestone

Successfully merging this pull request may close these issues.