Conversation

galz10

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

BEGIN_COMMIT_OVERRIDE
chore: added helper functions to DocumentWrapper
END_COMMIT_OVERRIDE

@galz10
feat: add get_document and list_document functions
d141a67
@galz10
fixed tests
1de3f02
@galz10
lint fix
1b9324f
@galz10
added tests and changed DocumentWrapper
446e187
@galz10
fixed failing test
ed86e84
@galz10
updated tests
9fc848b
@galz10
changed DocStrings and tests
88001da
@galz10
fixed failing test
1090173
@galz10
changed name and return type of list_documents
0cec6b5
@galz10
updated failing tests
0b67124
@galz10
lint fix
01e551f
@galz10
chore: updated comments
c25faf3
@galz10
updating naming for get_document to get_shards
cf8abef
@galz10
revert get_document changes
a8bbf7a
@galz10
Merge branch 'main' into update_comments
3c547e0
@galz10
lint fix
8df5b0b
@galz10
added code-block to comments
6ac3b43
@galz10
feat: add TableWrapper and helper functions
0b1b52a
@galz10
wrapped lines and paragraphs
fb81212
@galz10
Merge branch 'main' into wrap-table
eaabc42
@galz10
Merge branch 'main' into wrap-table
efc302f
@galz10
added tests for new features
88bbe01
@galz10
lint fix
f7ede09
@galz10
feat: added helper functions to DocumentWrapper
86c753c
@galz10
lint fix
8bcf3e2
@galz10galz10 requested a review from a team as a code owner October 12, 2022 18:36
@product-auto-labelproduct-auto-label bot added the size: mPull request size is medium.label Oct 12, 2022
@galz10galz10 requested a review from dizcology October 12, 2022 18:36
galz10
galz10 commented Oct 12, 2022
View reviewed changes
galz10
galz10 commented Oct 12, 2022
View reviewed changes
@galz10galz10 mentioned this pull request Oct 12, 2022
Merged
4 tasks
dizcology
dizcology requested changes Oct 13, 2022
View reviewed changes
@galz10galz10 requested a review from dizcology October 13, 2022 22:37
dizcology
dizcology requested changes Oct 18, 2022
View reviewed changes
@galz10galz10 requested a review from dizcology October 18, 2022 19:40
dizcology
dizcology reviewed Oct 19, 2022
View reviewed changes
google/cloud/documentai_toolbox/wrappers/document.py
target_string is not None and pattern is not None
):
raise ValueError(
"Exactly one of target_string and pattern must be specified."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "or" instead of "and".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is checking if both target_string and pattern are populated so it needs an "and" to make sure both are not none.

@galz10galz10 merged commit d103c08 into main Oct 19, 2022
@galz10galz10 deleted the add-helpers branch October 19, 2022 18:27
@release-pleaserelease-please bot mentioned this pull request Oct 19, 2022
Closed
@release-pleaserelease-please bot mentioned this pull request Dec 6, 2022
Merged
Sign up for free to join this conversation on . Already have an account? Sign in to comment

@dizcology dizcology dizcology approved these changes

No one assigned
size: mPull request size is medium.
None yet
No milestone

Successfully merging this pull request may close these issues.