Conversation

ntt2k

Add LeetCode extension as an activity bar item instead of a panel in Explorer item.

For some people with a lot of pre-existence extensions already bloated the Explorer, this PR separate Leetcode extension as an individual activity bar item for easier navigation.

capture

@jdneojdneo self-requested a review May 25, 2018 05:09
@jdneojdneo added the enhancementNew feature or requestlabel May 25, 2018
@jdneojdneo added this to the 0.6.0 milestone May 25, 2018
@jdneo

Very cool! Thanks for the contribution @ntt2k.

Just one concern. could we use space instead of tab in the package.json?

@jdneo

Created an issue for this PR: #39

@ntt2k

Yes, please. Thank you very much for accepting this.
You actually remind me one of the most famous developer's debate-->
https://www.youtube.com/watch?v=V7PLxL8jIl8

@jdneo

Haha, that's a classic debate.

Just want to make the indent same in this project.
Leave the choice to you when you are doing your own projects. 😄

package.json Outdated
"leetcode-cli": "2.5.1",
"opn": "^5.2.0"
},
"__metadata": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may not be a problem. Just curious about this field. Do you know where this field comes from?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this field could have come from vscode as I modified directly inside program's location on disk ".vscode\extensions" ... I think you can delete it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see...

Well I'm fine to change this myself, but I encourage that you can make the change directly in this PR, since this awesome feature is originally driven by you.

You can simply push the changes to your branch ntt2k:master then the PR here can automatically synced.

The changes we need to do are:

  • repleace tab to space
  • remove the __metadata fields in package.jon

Would you mind to do that? And please feel free to tell me if you have any question. 😄

@jdneojdneo merged commit b839a5d into LeetCode-OpenSource:master May 25, 2018
@jdneo

Pretty cool! thanks.

ringcrl pushed a commit to ringcrl/vscode-leetcode that referenced this pull request Apr 21, 2019
Sign up for free to join this conversation on . Already have an account? Sign in to comment
enhancementNew feature or request
None yet

Successfully merging this pull request may close these issues.