Fix Implicit true comparison (#244)

photodude · wilsonge · commit 148bb426cb97 · 2019-03-24T18:14:00.000Z
best practice to always avoid Implicit true comparisons (also mandated by PHPCS when contributing to their Repo)
diff --git a/Joomla/Sniffs/ControlStructures/ControlStructuresBracketsSniff.php b/Joomla/Sniffs/ControlStructures/ControlStructuresBracketsSniff.php
@@ -179,7 +179,7 @@ public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
 			 * Take into account any nested parenthesis that don't contribute to the level (often required for
 			 * closures and anonymous classes
 			 */
-			if (array_key_exists('nested_parenthesis', $tokens[$stackPtr]))
+			if (array_key_exists('nested_parenthesis', $tokens[$stackPtr]) === true)
 			{
 				$nested = count($tokens[$stackPtr]['nested_parenthesis']);
 			}

Original file line number	Diff line number	Diff line change
`@@ -179,7 +179,7 @@ public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)`
`179`	`179`	`* Take into account any nested parenthesis that don't contribute to the level (often required for`
`180`	`180`	`* closures and anonymous classes`
`181`	`181`	`*/`
`182`		`-if (array_key_exists('nested_parenthesis', $tokens[$stackPtr]))`
	`182`	`+if (array_key_exists('nested_parenthesis', $tokens[$stackPtr]) === true)`
`183`	`183`	`{`
`184`	`184`	`$nested = count($tokens[$stackPtr]['nested_parenthesis']);`
`185`	`185`	`}`