File tree
Expand file treeCollapse file tree1 file changed
+7
-7
lines changed Expand file treeCollapse file tree1 file changed
+7
-7
lines changed Original file line number | Diff line number | Diff line change |
---|
@@ -226,7 +226,7 @@ const menuConfig = {
|
226 | 226 | cancellable: true
|
227 | 227 | }
|
228 | 228 |
|
229 |
| -function createMenu(menuConfig) { |
| 229 | +function createMenu(config) { |
230 | 230 | // ...
|
231 | 231 | }
|
232 | 232 |
|
@@ -1699,14 +1699,14 @@ Promises are a built-in global type. Use them!
|
1699 | 1699 |
|
1700 | 1700 | **Bad:**
|
1701 | 1701 | ```javascript
|
1702 |
| -require('request').get('https://en.wikipedia.org/wiki/Robert_Cecil_Martin', function(err, response) { |
1703 |
| -if (err) { |
1704 |
| -console.error(err); |
| 1702 | +require('request').get('https://en.wikipedia.org/wiki/Robert_Cecil_Martin', (requestErr, response) => { |
| 1703 | +if (requestErr) { |
| 1704 | +console.error(requestErr); |
1705 | 1705 | }
|
1706 | 1706 | else {
|
1707 |
| -require('fs').writeFile('article.html', response.body, function(err) { |
1708 |
| -if (err) { |
1709 |
| -console.error(err); |
| 1707 | +require('fs').writeFile('article.html', response.body, (writeErr) => { |
| 1708 | +if (writeErr) { |
| 1709 | +console.error(writeErr); |
1710 | 1710 | } else {
|
1711 | 1711 | console.log('File written');
|
1712 | 1712 | }
|
|
You can’t perform that action at this time.
0 commit comments