Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ied is now only raised when that is indeed the case.
Hey, thank you for your quick response.
|
yup, definitely
ah I see, thanks |
…lti_column_raises method in test_constructors.py.
…olumn_raises to a raw string.
Nice, thanks! Can you add a whatsnew note to |
doc/source/whatsnew/v2.1.0.rst Outdated
| @@ -241,6 +241,7 @@ Styler | |||
| Other | |||
| ^^^^^ | |||
| - Bug in :func:`assert_almost_equal` now throwing assertion error for two unequal sets (:issue:`51727`) | |||
| - Bug in :func:`_check_values_indices_shape_match` no longer raises ValueError with a message saying that indices were specified when creating an empty DataFrame that has an issue with the number of columns in the data and in the columns argument. | |||
There was a problem hiding this comment.
This needs to have an issue number (even if there's no issue, so here you can put the PR number, i.e. 52084)
Also, I think this would fit better in the "Other enhancements" section, as that's where some other error messages are?
Finally, the note needs to be user-facing and can't mention private methods. How about "Improved error message when creating DataFrame with empty data, no index, and wrong number of columns"?
… the visible behavior for the library user instead of the behavior of a private method.
mroeschke approved these changes Mar 20, 2023
Thanks @Xargonus |
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
…ied is now only raised when that is indeed the case.
The following example incorrectly triggers the ValueError saying that "Empty data passed with indices specified."
pd.DataFrame(np.zeros((0, 2)), columns=['a', 'b', 'c'])doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.