Conversation

jbrockmendel
  • closes #xxxx (Replace xxxx with the issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@jbrockmendel

@MarcoGorelli this was the root cause of something you were looking at a few weeks ago, but i dont remember what the motivating issue was

MarcoGorelli
MarcoGorelli approved these changes Jul 13, 2023
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

I don't remember raising this, but looks good

@MarcoGorelliMarcoGorelli added this to the 2.1 milestone Jul 13, 2023
@MarcoGorelliMarcoGorelli added the DatetimeDatetime data dtypelabel Jul 13, 2023
@MarcoGorelliMarcoGorelli merged commit 7672459 into pandas-dev:main Jul 13, 2023
@jbrockmendeljbrockmendel deleted the bug-time-unit branch July 13, 2023 13:52
@jbrockmendeljbrockmendel mentioned this pull request Jul 18, 2023
Closed
3 tasks
Sign up for free to join this conversation on . Already have an account? Sign in to comment

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

No one assigned
DatetimeDatetime data dtype
None yet
2.1

Successfully merging this pull request may close these issues.