Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @@ -2317,7 +2318,8 @@ def translate(self, table): | |||
| dtype: object | |||
| """ | |||
| result = self._data.array._str_translate(table) | |||
| return self._wrap_result(result) | |||
| dtype = object if self._data.dtype == "object" else None | |||
| return self._wrap_result(result, dtype=dtype) | |||
There was a problem hiding this comment.
Maybe dumb question, but we can't just pass dtype=self._data.dtype and have the result dtype be correct in _wrap_result (with maybe additional logic)?
There was a problem hiding this comment.
Categoricals act out then, that's a bit confusing to me as well, but I didn't want to focus on this now.
mroeschke approved these changes Nov 26, 2023
Thanks @phofl |
Sorry this was meant for 2.1.4, should have added the milestone |
@meeseeksdev backport 2.1.x |
phofl added a commit that referenced this pull request Nov 26, 2023
…e with new string dtype) (#56185) Backport PR #56152: BUG: translate losing object dtype with new string dtype Co-authored-by: Patrick Hoefler <[email protected]>
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.