Use more specific node-type

staabm · staabm · commit 87dea4753aa7 · 2024-12-13T11:48:43.000+01:00
diff --git a/src/Rules/PHPUnit/AssertSameBooleanExpectedRule.php b/src/Rules/PHPUnit/AssertSameBooleanExpectedRule.php
@@ -3,6 +3,7 @@
 namespace PHPStan\Rules\PHPUnit;
 
 use PhpParser\Node;
+use PhpParser\Node\Expr\CallLike;
 use PhpParser\Node\Expr\ConstFetch;
 use PhpParser\NodeAbstract;
 use PHPStan\Analyser\Scope;
@@ -18,7 +19,7 @@ class AssertSameBooleanExpectedRule implements Rule
 
 	public function getNodeType(): string
 	{
-		return NodeAbstract::class;
+		return CallLike::class;
 	}
 
 	public function processNode(Node $node, Scope $scope): array
diff --git a/src/Rules/PHPUnit/AssertSameNullExpectedRule.php b/src/Rules/PHPUnit/AssertSameNullExpectedRule.php
@@ -3,6 +3,7 @@
 namespace PHPStan\Rules\PHPUnit;
 
 use PhpParser\Node;
+use PhpParser\Node\Expr\CallLike;
 use PhpParser\Node\Expr\ConstFetch;
 use PhpParser\NodeAbstract;
 use PHPStan\Analyser\Scope;
@@ -18,7 +19,7 @@ class AssertSameNullExpectedRule implements Rule
 
 	public function getNodeType(): string
 	{
-		return NodeAbstract::class;
+		return CallLike::class;
 	}
 
 	public function processNode(Node $node, Scope $scope): array
diff --git a/src/Rules/PHPUnit/AssertSameWithCountRule.php b/src/Rules/PHPUnit/AssertSameWithCountRule.php
@@ -4,6 +4,7 @@
 
 use Countable;
 use PhpParser\Node;
+use PhpParser\Node\Expr\CallLike;
 use PhpParser\NodeAbstract;
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\Rule;
@@ -19,7 +20,7 @@ class AssertSameWithCountRule implements Rule
 
 	public function getNodeType(): string
 	{
-		return NodeAbstract::class;
+		return CallLike::class;
 	}
 
 	public function processNode(Node $node, Scope $scope): array

Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,7 @@`
`3`	`3`	`namespace PHPStan\Rules\PHPUnit;`
`4`	`4`
`5`	`5`	`use PhpParser\Node;`
	`6`	`+use PhpParser\Node\Expr\CallLike;`
`6`	`7`	`use PhpParser\Node\Expr\ConstFetch;`
`7`	`8`	`use PhpParser\NodeAbstract;`
`8`	`9`	`use PHPStan\Analyser\Scope;`
`@@ -18,7 +19,7 @@ class AssertSameBooleanExpectedRule implements Rule`
`18`	`19`
`19`	`20`	`public function getNodeType(): string`
`20`	`21`	`{`
`21`		`-return NodeAbstract::class;`
	`22`	`+return CallLike::class;`
`22`	`23`	`}`
`23`	`24`
`24`	`25`	`public function processNode(Node $node, Scope $scope): array`
Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@`
`4`	`4`
`5`	`5`	`use Countable;`
`6`	`6`	`use PhpParser\Node;`
	`7`	`+use PhpParser\Node\Expr\CallLike;`
`7`	`8`	`use PhpParser\NodeAbstract;`
`8`	`9`	`use PHPStan\Analyser\Scope;`
`9`	`10`	`use PHPStan\Rules\Rule;`
`@@ -19,7 +20,7 @@ class AssertSameWithCountRule implements Rule`
`19`	`20`
`20`	`21`	`public function getNodeType(): string`
`21`	`22`	`{`
`22`		`-return NodeAbstract::class;`
	`23`	`+return CallLike::class;`
`23`	`24`	`}`
`24`	`25`
`25`	`26`	`public function processNode(Node $node, Scope $scope): array`