minor symfony#9933 Improved the front controller of the HttpCache (javiereguiluz)

javiereguiluz · javiereguiluz · commit 872500f1d3f1 · 2018-06-20T08:50:04.000+02:00
This PR was squashed before being merged into the 4.0 branch (closes symfony#9933). Discussion ---------- Improved the front controller of the HttpCache I don't think it makes sense to enable HttpCache in `dev` (in the past we only added this to `web/app.php` and not `web/app_dev.php`). The change in the `+ use App\CacheKernel;` (lines 98 and 99) is to sort the `use ...` alphabetically. Commits ------- 46c6c02 Improved the front controller of the HttpCache
diff --git a/http_cache.rst b/http_cache.rst
@@ -95,14 +95,19 @@ caching kernel:
 
     // public/index.php
 
-    use App\Kernel;
     + use App\CacheKernel;
+    use App\Kernel;
 
     // ...
-    $kernel = new Kernel($_SERVER['APP_ENV'] ?? 'dev', $_SERVER['APP_DEBUG'] ?? ('prod' !== ($_SERVER['APP_ENV'] ?? 'dev')));
+    $env = $_SERVER['APP_ENV'] ?? 'dev';
+    $debug = (bool) ($_SERVER['APP_DEBUG'] ?? ('prod' !== $env));
+    // ...
+    $kernel = new Kernel($env, $debug);
 
-    + // Wrap the default Kernel with the CacheKernel one
-    + $kernel = new CacheKernel($kernel);
+    + // Wrap the default Kernel with the CacheKernel one in 'prod' environment
+    + if ('prod' === $env) {
+    +     $kernel = new CacheKernel($kernel);
+    + }
 
     $request = Request::createFromGlobals();
     // ...
