Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
BREAKING CHANGE: adds a new checked exception as a return type of the utils module public API
e64484b to 87cacfe Compare In my view no need to ever make it a direct subclass of Exception. Your second alternative option of a dedicated subclass of IOException would be perfectly valid as a final solution to offer the opportunity to separately catch it in cases where you'd like to handle it differently from other I/O errors. |
jeremylong approved these changes Apr 7, 2025
9640164 into main 10 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Sign up for free to subscribe to this conversation on . Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description of Change
The proposed change aims to add a more explicit message to the user when it is facing an HTTP 403 status code from Maven central search.
The change introduces
ForbiddenException, a subclass ofIOException. This fully preserve the behavior of any code using the utils module as a dependency.I am open to comments and discussions on this change proposal, thank you for your help!
Related issues
Fixes #7510
Have test cases been added to cover the new functionality?
no