Conversation

patak-dev

Description

A favicon.ico request is returning the index.html because it has */* in its header. It seems that checking against image/ should work.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@bolt-new-by-stackblitzBolt.new (by StackBlitz)

Review PR in StackBlitz CodeflowRun & review this pull request in StackBlitz Codeflow.

ArnaudBarre
ArnaudBarre previously approved these changes Dec 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was intentional that the html fallback also apply to images, especially when we removed the dot rule. Perhaps we could special case for favicon.ico only? cc @sapphi-red

@sapphi-red

Yeah, if */* is included, we have to treat the same with text/html. I think a special case for favicon.ico makes sense. We already have a similar check here.

const knownIgnoreList = new Set(['/', '/favicon.ico'])

@patak-dev

Thanks! Updated to directly avoid the default /favicon.ico request.

@patak-devpatak-dev added the p3-minor-bugAn edge case that only affects very specific usage (priority)label Dec 12, 2023
@patak-devpatak-dev merged commit c902545 into main Dec 12, 2023
@patak-devpatak-dev deleted the fix/html-fallback-for-favicon branch December 12, 2023 21:43
Sign up for free to join this conversation on . Already have an account? Sign in to comment
p3-minor-bugAn edge case that only affects very specific usage (priority)
None yet

Successfully merging this pull request may close these issues.