chore(java): ignore return code 28 in README autosynth job (#211)

yoshi-automation · web-flow · commit c7abdb63b324 · 2020-11-17T16:45:09.000-05:00
Exit code 28 is returned if no changes are required and should not be considered a failure. Source-Author: Jeff Ching <chingor@google.com> Source-Date: Mon Nov 9 14:51:28 2020 -0800 Source-Repo: googleapis/synthtool Source-Sha: 7db8a6c5ffb12a6e4c2f799c18f00f7f3d60e279 Source-Link: googleapis/synthtool@7db8a6c
diff --git a/.kokoro/readme.sh b/.kokoro/readme.sh
@@ -28,9 +28,18 @@ echo "https://${_TOKEN}:@.com" >> ~/.git-credentials
 git config --global credential.helper 'store --file ~/.git-credentials'
 
 python3.6 -m pip install git+https://.com/googleapis/synthtool.git#egg=gcp-synthtool
+
+set +e
 python3.6 -m autosynth.synth \
     --repository=googleapis/java-shared-dependencies \
     --synth-file-name=./readme/synth.py \
     --metadata-path=./readme/synth.metadata \
     --pr-title="chore: regenerate README" \
-    --branch-suffix="readme"
+    --branch-suffix="readme"
+
+# autosynth returns 28 to signal there are no changes
+RETURN_CODE=$?
+if [[ ${RETURN_CODE} -ne 0 && ${RETURN_CODE} -ne 28 ]]
+then
+    exit ${RETURN_CODE}
+fi
diff --git a/synth.metadata b/synth.metadata
@@ -4,14 +4,14 @@
       "git": {
         "name": ".",
         "remote": "https://.com/googleapis/java-shared-dependencies.git",
-        "sha": "e6fc95a27ec4c3c6419da3e40157f64da24e1c73"
+        "sha": "b09094fe36f28dad83d51d71017835c0daa40bef"
       }
     },
     {
       "git": {
         "name": "synthtool",
         "remote": "https://.com/googleapis/synthtool.git",
-        "sha": "c7824ea48ff6d4d42dfae0849aec8a85acd90bd9"
+        "sha": "7db8a6c5ffb12a6e4c2f799c18f00f7f3d60e279"
       }
     }
   ],

Original file line number	Diff line number	Diff line change
`@@ -4,14 +4,14 @@`
`4`	`4`	`"git": {`
`5`	`5`	`"name": ".",`
`6`	`6`	`"remote": "https://.com/googleapis/java-shared-dependencies.git",`
`7`		`-"sha": "e6fc95a27ec4c3c6419da3e40157f64da24e1c73"`
	`7`	`+"sha": "b09094fe36f28dad83d51d71017835c0daa40bef"`
`8`	`8`	`}`
`9`	`9`	`},`
`10`	`10`	`{`
`11`	`11`	`"git": {`
`12`	`12`	`"name": "synthtool",`
`13`	`13`	`"remote": "https://.com/googleapis/synthtool.git",`
`14`		`-"sha": "c7824ea48ff6d4d42dfae0849aec8a85acd90bd9"`
	`14`	`+"sha": "7db8a6c5ffb12a6e4c2f799c18f00f7f3d60e279"`
`15`	`15`	`}`
`16`	`16`	`}`
`17`	`17`	`],`