Conversation

voidzcy

Avoid buffering RPCs when subchannel is CONNECTING after being TRANSIENT_FAILURE.

See #6650 for description of the issue. This PR fixes RR load balancer only.

@voidzcyvoidzcy requested a review from ejona86 January 29, 2020 21:42
@zhangkun83zhangkun83 removed their request for review January 30, 2020 21:15
@voidzcyvoidzcy removed the request for review from ejona86 April 3, 2020 02:18
@voidzcyvoidzcy changed the title core: keep round_robin lb subchannel in TRANSIENT_FAILURE until becoming READY core: keep round_robin lb in TRANSIENT_FAILURE until becoming READY Apr 3, 2020
@voidzcyvoidzcy changed the title core: keep round_robin lb in TRANSIENT_FAILURE until becoming READY core: keep round_robin lb subchannel in TRANSIENT_FAILURE until becoming READY Apr 3, 2020
@voidzcyvoidzcy requested a review from ejona86 April 3, 2020 22:40
@voidzcyvoidzcy merged commit 8e9ceb5 into grpc:master Apr 6, 2020
dfawley pushed a commit to dfawley/grpc-java that referenced this pull request Jan 15, 2021
…ing READY (grpc#6657)

Make each subchannel created by RR stay in TRANSIENT_FAILURE state until READY. That is, each subchannel ignores consequent non-READY states after TRANSIENT_FAILURE.
zhangkun83 added a commit to zhangkun83/grpc-java that referenced this pull request Jan 15, 2021
…READY

If all RR servers are unhealthy, it's possible that at least one
connection is CONNECTING at every moment which causes RR to stay in
CONNECTING. It's better to keep the TRANSIENT_FAILURE state in that
case so that fail-fast RPCs can fail fast.

The same changes have been made for RoundRobinLoadBalancer in grpc#6657
zhangkun83 added a commit that referenced this pull request Jan 15, 2021
…READY (#7816)

If all RR servers are unhealthy, it's possible that at least one
connection is CONNECTING at every moment which causes RR to stay in
CONNECTING. It's better to keep the TRANSIENT_FAILURE state in that
case so that fail-fast RPCs can fail fast.

The same changes have been made for RoundRobinLoadBalancer in #6657
@github-actions-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2021
Sign up for free to subscribe to this conversation on . Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.