Conversation

elharo

ejona86
ejona86 reviewed Feb 25, 2020
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Truth upgrade is fine, but we generally want junit to stay in sync with internal junit version, which is on 4.12 at the moment.

elharo
elharo commented Feb 26, 2020
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted JUnit

creamsoup
creamsoup reviewed Feb 26, 2020
View reviewed changes
@dapengzhang0dapengzhang0 added the kokoro:runAdd this label to a PR to tell Kokoro the code is safe and tests can be runlabel Feb 26, 2020
@grpc-kokorogrpc-kokoro removed the kokoro:runAdd this label to a PR to tell Kokoro the code is safe and tests can be runlabel Feb 26, 2020
@creamsoupcreamsoup merged commit 159632c into grpc:master Feb 26, 2020
@creamsoup

merged thanks @elharo!

dfawley pushed a commit to dfawley/grpc-java that referenced this pull request Jan 15, 2021
@elharo @dfawley
Update truth version to 1.0.1 (grpc#6754)
e5f893c
@github-actions-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2021
Sign up for free to subscribe to this conversation on . Already have an account? Sign in.

@ejona86 ejona86 ejona86 left review comments

@creamsoup creamsoup creamsoup approved these changes

@dapengzhang0 dapengzhang0 dapengzhang0 approved these changes

No one assigned
None yet
None yet
No milestone

Successfully merging this pull request may close these issues.