Conversation

elharo

@elharoelharo changed the title Onlyguava Update guava to 29.0 Jun 1, 2020
@elharo
> Task :grpc-context:compileTestJava FAILED
/home/travis/build/grpc/grpc-java/context/src/test/java/io/grpc/ContextTest.java:784: warning: [deprecation] <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated
    assertThat(context.cancellationCause(), instanceOf(TimeoutException.class));
    ^
  where T is a type-variable:
    T extends Object declared in method <T>assertThat(T,Matcher<? super T>)
/home/travis/build/grpc/grpc-java/context/src/test/java/io/grpc/ContextTest.java:791: warning: [deprecation] <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated
    assertThat(context.cancellationCause(), instanceOf(TimeoutException.class));
    ^
  where T is a type-variable:
    T extends Object declared in method <T>assertThat(T,Matcher<? super T>)
error: warnings found and -Werror specified
1 error
2 warnings

@elharo

Foxed locally, for some reason the PR doesn't have that change. I hate git.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exclusion of JUnit doesn't seem to be working. @dapengzhang0 any ideas?

build.gradle Outdated
@@ -312,6 +312,9 @@ subprojects {
testCompile libraries.junit,
libraries.mockito,
libraries.truth
testImplementation (libraries.guava_testlib) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not be done here. Search for usage of libraries.guava_testlib and change each of them with exclusion. (census/build.gradle uses libraries.guava_testlib but actually it should not)

@dapengzhang0dapengzhang0 added the kokoro:runAdd this label to a PR to tell Kokoro the code is safe and tests can be runlabel Jun 3, 2020
@grpc-kokorogrpc-kokoro removed the kokoro:runAdd this label to a PR to tell Kokoro the code is safe and tests can be runlabel Jun 3, 2020
build.gradle Outdated
@@ -187,7 +187,7 @@ subprojects {
// Jetty ALPN dependencies
jetty_alpn_agent: 'org.mortbay.jetty.alpn:jetty-alpn-agent:2.0.9'
]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove 8 white spaces

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -18,8 +18,9 @@ dependencies {
testImplementation project(':grpc-context').sourceSets.test.output,
project(':grpc-testing'),
project(':grpc-grpclb'),
libraries.guava_testlib

testImplementation (libraries.guava_testlib) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the comma above, otherwise this is considered as appending its return value to the above list, although not breaking.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@dapengzhang0dapengzhang0 added the kokoro:runAdd this label to a PR to tell Kokoro the code is safe and tests can be runlabel Jun 3, 2020
@grpc-kokorogrpc-kokoro removed the kokoro:runAdd this label to a PR to tell Kokoro the code is safe and tests can be runlabel Jun 3, 2020
@elharo

Thanks. You need to merge this as I don't have committer rights.

@dapengzhang0dapengzhang0 merged commit 417d770 into grpc:master Jun 3, 2020
@dapengzhang0

@elharo Thank you for your PR.

dfawley pushed a commit to dfawley/grpc-java that referenced this pull request Jan 15, 2021
@elharoelharo deleted the onlyguava branch April 21, 2021 20:36
@github-actions-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2021
Sign up for free to subscribe to this conversation on . Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

Bump Guava to 29.0-android