Conversation

susinmotion

This is used for an internal name resolver.

@linux-foundation-easycla

CLA Check
The committers are authorized under a signed CLA.

ejona86
ejona86 approved these changes Jul 21, 2020
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having NameResolvers use the internal API, it seems exposing this is fair. ATTR_LB_ADDR_AUTHORITY is useless without this attribute.

@ejona86ejona86 requested a review from voidzcy July 21, 2020 17:48
@ejona86ejona86 changed the title Make ATTR_LB_ADDRS public. grpclb: Make ATTR_LB_ADDRS public. Jul 21, 2020
@ejona86ejona86 added the kokoro:runAdd this label to a PR to tell Kokoro the code is safe and tests can be runlabel Jul 21, 2020
@grpc-kokorogrpc-kokoro removed the kokoro:runAdd this label to a PR to tell Kokoro the code is safe and tests can be runlabel Jul 21, 2020
@voidzcyvoidzcy merged commit 2473110 into grpc:master Jul 21, 2020
dfawley pushed a commit to dfawley/grpc-java that referenced this pull request Jan 15, 2021
@susinmotion @dfawley
grpclb: Make ATTR_LB_ADDRS public (grpc#7230)
a76e0c6
@github-actions-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on . Already have an account? Sign in.

@voidzcy voidzcy voidzcy approved these changes

@ejona86 ejona86 ejona86 approved these changes

No one assigned
None yet
None yet
No milestone

Successfully merging this pull request may close these issues.