Conversation

floriansimon1

This is useful for Conan recipes that build Protobuf, in which
whatever we want to enable has to be enabled in the initial command line.
Without this, the people maintaining the recipe have to the CMake
setup of Protobuf before building the binaries.

Closes #5541

@google-cla

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your account.

ℹ️ Googlers: Go here for more info.

This is useful for Conan recipes that build Protobuf, in which
whatever we want to enable has to be enabled in the initial command line.
Without this, the people maintaining the recipe have to  the CMake
setup of Protobuf before building the binaries.

Closes #5541
@acozzette

Thanks, @floriansimon1.

@floriansimon1

My pleasure!

Do we know when the next release is planned?

@acozzette

We don't have a set release schedule but we seem to average once every quarter or so. If you want to have this in a release version sooner then feel free to send me another PR cherry-picking this to the 3.15.x branch because we are probably going to do a 3.15.4 release this week.

@floriansimon1

@floriansimon1floriansimon1 deleted the allow-disabling-rtti-from-cmake-command-line branch March 2, 2021 19:21
@floriansimon1

@acozzette > There! #8361

Sign up for free to join this conversation on . Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

Add CMake option to define GOOGLE_PROTOBUF_NO_RTTI