Support HTTP 204 (#11408)

sidwarkd · me-no-dev · web-flow · commit b5c5655cf004 · 2025-06-04T17:39:19.000+03:00
HTTP 204 is a successful return code which indicates No Content. While it's appropriate to return a 304 if the server has content for a device but it hasn't change, it is more accurate for a server to return a 204 if it simply doesn't have any firmware files for a particular device.

Co-authored-by: Me No Dev &lt;me-no-dev@users.noreply..com&gt;
diff --git a/libraries/HTTPUpdate/src/HTTPUpdate.cpp b/libraries/HTTPUpdate/src/HTTPUpdate.cpp
@@ -356,6 +356,7 @@ HTTPUpdateResult HTTPUpdate::handleUpdate(HTTPClient &http, const String &curren
         log_e("Content-Length was 0 or wasn't set by Server?!\n");
       }
       break;
+    case HTTP_CODE_NO_CONTENT:
     case HTTP_CODE_NOT_MODIFIED:
       ///< Not Modified (No updates)
       ret = HTTP_UPDATE_NO_UPDATES;

Original file line number	Diff line number	Diff line change
`@@ -356,6 +356,7 @@ HTTPUpdateResult HTTPUpdate::handleUpdate(HTTPClient &http, const String &curren`
`356`	`356`	`log_e("Content-Length was 0 or wasn't set by Server?!\n");`
`357`	`357`	`}`
`358`	`358`	`break;`
	`359`	`+case HTTP_CODE_NO_CONTENT:`
`359`	`360`	`case HTTP_CODE_NOT_MODIFIED:`
`360`	`361`	`///< Not Modified (No updates)`
`361`	`362`	`ret = HTTP_UPDATE_NO_UPDATES;`