Conversation

wildhemp

According to https://cloud.google.com/stackdriver/docs/solutions/gke/migration#resource-changes container is legacy the new type is k8s_container.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@wildhempwildhemp requested review from a team as code owners August 25, 2021 17:02
@product-auto-labelproduct-auto-label bot added the api: loggingIssues related to the googleapis/java-logging API.label Aug 25, 2021
@google-clagoogle-cla bot added the cla: yesThis human has signed the Contributor License Agreement.label Aug 25, 2021
@simonz130simonz130 added the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label Sep 9, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label Sep 9, 2021
@simonz130simonz130 added theMerge the pull request once unit tests and other checks pass.label Sep 10, 2021
@gcf-merge-on-green

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help..com/en//administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-greengcf-merge-on-green bot removed the automergeMerge the pull request once unit tests and other checks pass.label Sep 10, 2021
@simonz130simonz130 added the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label Sep 14, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label Sep 14, 2021
@simonz130simonz130 added the kokoro:runAdd this label to force Kokoro to re-run the tests.label Sep 14, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:runAdd this label to force Kokoro to re-run the tests.label Sep 14, 2021
@simonz130simonz130 merged commit 6103560 into googleapis:master Sep 16, 2021
@wildhempwildhemp deleted the -1 branch September 16, 2021 18:58
Sign up for free to join this conversation on . Already have an account? Sign in to comment
api: loggingIssues related to the googleapis/java-logging API.cla: yesThis human has signed the Contributor License Agreement.
None yet

Successfully merging this pull request may close these issues.