File tree

3 files changed

+42
-7
lines changed

3 files changed

+42
-7
lines changed
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,11 @@ public void queryOptions() {
103103

104104
// Create a SpannerOptions with and without default query options.
105105
SpannerOptions optionsWithQueryOptions =
106-
new SpannerOptions.Builder(SpannerOptions.getDefaultInstance()) {
106+
new SpannerOptions.Builder(
107+
SpannerOptions.newBuilder()
108+
.setProjectId("some-project")
109+
.setCredentials(NoCredentials.getInstance())
110+
.build()) {
107111
@Override
108112
QueryOptions getEnvironmentQueryOptions() {
109113
// Override and return default instance to prevent environment variables from
@@ -112,7 +116,11 @@ QueryOptions getEnvironmentQueryOptions() {
112116
}
113117
}.setDefaultQueryOptions(db, queryOptions).build();
114118
SpannerOptions optionsWithoutQueryOptions =
115-
new SpannerOptions.Builder(SpannerOptions.getDefaultInstance()) {
119+
new SpannerOptions.Builder(
120+
SpannerOptions.newBuilder()
121+
.setProjectId("some-project")
122+
.setCredentials(NoCredentials.getInstance())
123+
.build()) {
116124
@Override
117125
QueryOptions getEnvironmentQueryOptions() {
118126
// Override and return default instance to prevent environment variables from
Original file line numberDiff line numberDiff line change
@@ -389,19 +389,36 @@ public void testDoNotCacheClosedSpannerInstance() {
389389
public void testSetClientLibToken() {
390390
final String jdbcToken = "sp-jdbc";
391391
final String hibernateToken = "sp-hib";
392-
SpannerOptions options = SpannerOptions.newBuilder().setClientLibToken(jdbcToken).build();
392+
SpannerOptions options =
393+
SpannerOptions.newBuilder()
394+
.setProjectId("some-project")
395+
.setCredentials(NoCredentials.getInstance())
396+
.setClientLibToken(jdbcToken)
397+
.build();
393398
assertThat(options.getClientLibToken()).isEqualTo(jdbcToken);
394399

395-
options = SpannerOptions.newBuilder().setClientLibToken(hibernateToken).build();
400+
options =
401+
SpannerOptions.newBuilder()
402+
.setProjectId("some-project")
403+
.setCredentials(NoCredentials.getInstance())
404+
.setClientLibToken(hibernateToken)
405+
.build();
396406
assertThat(options.getClientLibToken()).isEqualTo(hibernateToken);
397407

398-
options = SpannerOptions.newBuilder().build();
408+
options =
409+
SpannerOptions.newBuilder()
410+
.setProjectId("some-project")
411+
.setCredentials(NoCredentials.getInstance())
412+
.build();
399413
assertThat(options.getClientLibToken()).isEqualTo(ServiceOptions.getGoogApiClientLibName());
400414
}
401415

402416
@Test(expected = IllegalArgumentException.class)
403417
public void testSetInvalidClientLibToken() {
404-
SpannerOptions.newBuilder().setClientLibToken("foo");
418+
SpannerOptions.newBuilder()
419+
.setProjectId("some-project")
420+
.setCredentials(NoCredentials.getInstance())
421+
.setClientLibToken("foo");
405422
}
406423

407424
@Test
@@ -443,6 +460,8 @@ public String getOptimizerVersion() {
443460
.setDefaultQueryOptions(
444461
DatabaseId.of("p", "i", "d"),
445462
QueryOptions.newBuilder().setOptimizerVersion("1").build())
463+
.setProjectId("p")
464+
.setCredentials(NoCredentials.getInstance())
446465
.build();
447466
assertThat(options.getDefaultQueryOptions(DatabaseId.of("p", "i", "d")))
448467
.isEqualTo(QueryOptions.newBuilder().setOptimizerVersion("1").build());
@@ -464,6 +483,8 @@ public String getOptimizerVersion() {
464483
.setDefaultQueryOptions(
465484
DatabaseId.of("p", "i", "d"),
466485
QueryOptions.newBuilder().setOptimizerVersion("1").build())
486+
.setProjectId("p")
487+
.setCredentials(NoCredentials.getInstance())
467488
.build();
468489
assertThat(options.getDefaultQueryOptions(DatabaseId.of("p", "i", "d")))
469490
.isEqualTo(QueryOptions.newBuilder().setOptimizerVersion("2").build());
Original file line numberDiff line numberDiff line change
@@ -281,6 +281,7 @@ && getNumberOfThreadsWithName(SPANNER_THREAD_NAME, false)
281281
public void testCallCredentialsProviderPreferenceAboveCredentials() {
282282
SpannerOptions options =
283283
SpannerOptions.newBuilder()
284+
.setProjectId("some-project")
284285
.setCredentials(STATIC_CREDENTIALS)
285286
.setCallCredentialsProvider(
286287
new CallCredentialsProvider() {
@@ -302,6 +303,7 @@ public CallCredentials getCallCredentials() {
302303
public void testCallCredentialsProviderReturnsNull() {
303304
SpannerOptions options =
304305
SpannerOptions.newBuilder()
306+
.setProjectId("some-project")
305307
.setCredentials(STATIC_CREDENTIALS)
306308
.setCallCredentialsProvider(
307309
new CallCredentialsProvider() {
@@ -319,7 +321,11 @@ public CallCredentials getCallCredentials() {
319321

320322
@Test
321323
public void testNoCallCredentials() {
322-
SpannerOptions options = SpannerOptions.newBuilder().setCredentials(STATIC_CREDENTIALS).build();
324+
SpannerOptions options =
325+
SpannerOptions.newBuilder()
326+
.setProjectId("some-project")
327+
.setCredentials(STATIC_CREDENTIALS)
328+
.build();
323329
GapicSpannerRpc rpc = new GapicSpannerRpc(options);
324330
assertThat(rpc.newCallContext(optionsMap, "/some/resource").getCallOptions().getCredentials())
325331
.isNull();

0 commit comments

Comments
 (0)