@@ -126,8 +126,8 @@ private BatchCreateSessionsRunnable(
|
126 | 126 | public void run() {
|
127 | 127 | List<SessionImpl> sessions = null;
|
128 | 128 | int remainingSessionsToCreate = sessionCount;
|
129 |
| -try (Scope scope = |
130 |
| - SpannerImpl.tracer.spanBuilder(SpannerImpl.BATCH_CREATE_SESSIONS).startScopedSpan()) { |
| 129 | +Span span = SpannerImpl.tracer.spanBuilder(SpannerImpl.BATCH_CREATE_SESSIONS).startSpan(); |
| 130 | +try (Scope s = SpannerImpl.tracer.withSpan(span)) { |
131 | 131 | SpannerImpl.tracer
|
132 | 132 | .getCurrentSpan()
|
133 | 133 | .addAnnotation(String.format("Creating %d sessions", sessionCount));
|
@@ -144,6 +144,8 @@ public void run() {
|
144 | 144 | }
|
145 | 145 | remainingSessionsToCreate -= sessions.size();
|
146 | 146 | }
|
| 147 | +} finally { |
| 148 | +span.end(TraceUtil.END_SPAN_OPTIONS); |
147 | 149 | }
|
148 | 150 | }
|
149 | 151 | }
|
@@ -205,7 +207,7 @@ SessionImpl createSession() {
|
205 | 207 | spanner
|
206 | 208 | .getRpc()
|
207 | 209 | .createSession(db.getName(), spanner.getOptions().getSessionLabels(), options);
|
208 |
| -span.end(); |
| 210 | +span.end(TraceUtil.END_SPAN_OPTIONS); |
209 | 211 | return new SessionImpl(spanner, session.getName(), options);
|
210 | 212 | } catch (RuntimeException e) {
|
211 | 213 | TraceUtil.endSpanWithFailure(span, e);
|
@@ -284,7 +286,7 @@ private List<SessionImpl> internalBatchCreateSessions(
|
284 | 286 | span.addAnnotation(
|
285 | 287 | String.format(
|
286 | 288 | "Request for %d sessions returned %d sessions", sessionCount, sessions.size()));
|
287 |
| -span.end(); |
| 289 | +span.end(TraceUtil.END_SPAN_OPTIONS); |
288 | 290 | List<SessionImpl> res = new ArrayList<>(sessionCount);
|
289 | 291 | for (com.google.spanner.v1.Session session : sessions) {
|
290 | 292 | res.add(new SessionImpl(spanner, session.getName(), options));
|
|
0 commit comments