Adds the method getValue to the ResultSet. This will return an encapsulated value. It supports all the column types that are provided.

[thiagotnunes]

Clirr does not support Java 8 features, so it thinks these are breaking changes, where in fact we have provided default implementations for the added interface methods. No need for a major release here.

@olavloite got it, thanks for the feedback. I've re-implemented with a less intrusive manner, let me know if that makes sense.

[olavloite]

I think it would be good to add null values for INT64 and FLOAT64 arrays as well in this test. Arrays of all types can always contain null values, regardless whether the column itself is nullable, and regardless of the array element type.

[thiagotnunes]

These throw a NPE as they do if you use a resultSet.getLongArray(...) or resultSet.getDoubleArray(...). I could test the exception if you feel like we should.

[olavloite]

No, in that case I actually think we should change the implementation. It is logical that resultSet.getDoubleArray(..) throws an NPE. I don't think it is logical that resultSet.getValue("some-float64-array-col") should ever throw an NPE because one of the elements is null, as a Value can hold a null value for an element of an ARRAY<FLOAT64>.

[thiagotnunes]

Changed the implementation to support nulls in arrays and added tests for it.

In regards to a single null value as in SELECT column FROM table (where column value is null), when we do a getValue it is currently throwing an exception as if we called a resultSet.getString(...). Do you think we should change this as well?

[olavloite]

Yes, I think we should change that as well now that we have a chance. Value also has an isNull() method, so it would make sense to let resultSet.getValue(...) return a Value instance when the column is null. The user can then check whether the value is actually null by calling Value#isNull().

[thiagotnunes]

Awesome, changed the implementation to allow for that. If you could re-review, I'd appreciate it.

This looks good to me, but I think for completeness it would be good to add null values to the integration tests for all array types. Now the primitive types are missing (Long and Double).

[thiagotnunes]

@olavloite I made this method public. It surprising me that this was not public before, since users can SELECT ARRAY(SELECT STRUCT ...) and would not be able to get the results.

Codecov Report

Merging #1073 (cab531b) into master (1eeb6aa) will decrease coverage by 0.24%.
The diff coverage is 21.15%.

@@             Coverage Diff              @@
##             master    #1073      +/-   ##
============================================
- Coverage     85.17%   84.93%   -0.25%     
- Complexity     2719     2727       +8     
============================================
  Files           155      156       +1     
  Lines         14351    14403      +52     
  Branches       1358     1380      +22     
============================================
+ Hits          12224    12233       +9     
- Misses         1558     1603      +45     
+ Partials        569      567       -2     

Impacted Files	Coverage Δ	Complexity Δ
...va/com/google/cloud/spanner/AbstractResultSet.java	79.13% <0.00%> (-4.32%)	28.00 <0.00> (ø)
...m/google/cloud/spanner/ForwardingStructReader.java	24.27% <0.00%> (-0.99%)	12.00 <0.00> (ø)
...in/java/com/google/cloud/spanner/StructReader.java	0.00% <0.00%> (ø)	0.00 <0.00> (?)
.../src/main/java/com/google/cloud/spanner/Value.java	87.81% <ø> (ø)	63.00 <0.00> (ø)
...oud/spanner/connection/DirectExecuteResultSet.java	96.77% <50.00%> (-1.56%)	61.00 <2.00> (+2.00)	⬇️
...ner/connection/ReplaceableForwardingResultSet.java	96.72% <50.00%> (-1.59%)	58.00 <2.00> (+2.00)	⬇️
...com/google/cloud/spanner/AbstractStructReader.java	98.40% <80.00%> (-0.77%)	53.00 <2.00> (+2.00)	⬇️
...main/java/com/google/cloud/spanner/ResultSets.java	97.08% <100.00%> (+0.05%)	5.00 <0.00> (ø)
...src/main/java/com/google/cloud/spanner/Struct.java	88.78% <100.00%> (+0.10%)	28.00 <0.00> (ø)
.../google/cloud/spanner/AbstractLazyInitializer.java	92.85% <0.00%> (-7.15%)	4.00% <0.00%> (-1.00%)
... and 6 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eeb6aa...cab531b. Read the comment docs.

[olavloite]

nit: This should be updated to indicate that this method can be called for columns that contain a null value, and what the behavior is when the value is null.