Conversation

allenpradeep

This adds keepalives to the GRPC channel every 2 minutes. By default, there are no keepalives to the GRPC channel. While running dataflow import jobs, issues have been observed with the spanner commit calls that run more than 10 minutes. Adding keepalives to the GRPC channel solves these issues.

@googlebotgooglebot added the cla: yesThis human has signed the Contributor License Agreement.label Jan 6, 2020
chore: update common templates (#12)
This  adds keepalives to the GRPC channel every 2 minutes. By
default, there are no keepalives to the GRPC channel. While running
dataflow import jobs, issues have been observed with the spanner
commit calls that run more than 10 minutes. Adding keepalives to
the GRPC channel solves these issues.
@allenpradeepallenpradeep changed the title Add keepalives to GRPC channel fix: add keepalives to GRPC channel Jan 7, 2020
@allenpradeep

@skuruppu - Can you please take a look at this.

@skuruppuskuruppu requested a review from olavloite January 9, 2020 05:03

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@allenpradeep

Hi @skuruppu,
I dont have write access to the repository. Can someone with write access merge this pull request?

@olavloiteolavloite merged commit 428a4a6 into googleapis:master Jan 14, 2020
@allenpradeep

Thanks @olavloite

Sign up for free to join this conversation on . Already have an account? Sign in to comment
cla: yesThis human has signed the Contributor License Agreement.
None yet

Successfully merging this pull request may close these issues.