Conversation

olavloite

The restore operation should use the default timeout of a restore operation. Although that timeout is long, the tests for the samples are only executed as part of the nightly build, which means that a long-running restore will not slow down PR builds.

Fixes #1019

The restore operation should use the default timeout of a restore operation.
Although that timeout is long, the tests for the samples are only executed as
part of the nightly build, which means that a long-running restore will not
slow down PR builds.

Fixes #1019
@olavloiteolavloite requested a review from a team as a code owner April 28, 2021 11:01
@olavloiteolavloite requested a review from a team April 28, 2021 11:01
@google-clagoogle-cla bot added theThis human has signed the Contributor License Agreement.label Apr 28, 2021
@product-auto-labelproduct-auto-label bot added the api: spannerIssues related to the googleapis/java-spanner API.label Apr 28, 2021
@codecov

Codecov Report

Merging #1109 (a558b26) into master (37ca990) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1109      +/-   ##
============================================
- Coverage     84.99%   84.96%   -0.03%     
+ Complexity     2727     2723       -4     
============================================
  Files           156      156              
  Lines         14410    14410              
  Branches       1379     1379              
============================================
- Hits          12248    12244       -4     
- Misses         1593     1597       +4     
  Partials        569      569              
Impacted FilesCoverage ΔComplexity Δ
.../google/cloud/spanner/AbstractLazyInitializer.java92.85% <0.00%> (-7.15%)4.00% <0.00%> (-1.00%)
...ud/spanner/SessionPoolAsyncTransactionManager.java85.03% <0.00%> (-1.58%)13.00% <0.00%> (-2.00%)
...m/google/cloud/spanner/connection/SpannerPool.java87.16% <0.00%> (-0.54%)33.00% <0.00%> (ø%)
...ain/java/com/google/cloud/spanner/SessionPool.java89.01% <0.00%> (ø)74.00% <0.00%> (ø%)
...a/com/google/cloud/spanner/SessionPoolOptions.java69.53% <0.00%> (ø)17.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37ca990...a558b26. Read the comment docs.

@thiagotnunesthiagotnunes merged commit 3f3c13e into master Apr 29, 2021
@thiagotnunesthiagotnunes deleted the use-default-timeout branch April 29, 2021 00:34
Sign up for free to join this conversation on . Already have an account? Sign in to comment
api: spannerIssues related to the googleapis/java-spanner API.cla: yesThis human has signed the Contributor License Agreement.
None yet

Successfully merging this pull request may close these issues.

com.example.spanner.EncryptionKeyIT: testEncryptedDatabaseAndBackupAndRestore failed