Conversation

olavloite

Adding a custom user-agent was only possible by using an all lower-case key. A header key should however be case-insensitive. This PR changes the merging of a custom user-agent value with the default user-agent to use a case-insensitive comparison.

@olavloiteolavloite requested a review from a team as a code owner April 28, 2021 12:19
@google-clagoogle-cla bot added the cla: yesThis human has signed the Contributor License Agreement.label Apr 28, 2021
@product-auto-labelproduct-auto-label bot added the api: spannerIssues related to the googleapis/java-spanner API.label Apr 28, 2021
@codecov

Codecov Report

Merging #1110 (ea7dea0) into master (37ca990) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1110      +/-   ##
============================================
- Coverage     84.99%   84.99%   -0.01%     
  Complexity     2727     2727              
============================================
  Files           156      156              
  Lines         14410    14416       +6     
  Branches       1379     1381       +2     
============================================
+ Hits          12248    12253       +5     
- Misses         1593     1596       +3     
+ Partials        569      567       -2     
Impacted FilesCoverage ΔComplexity Δ
...m/google/cloud/spanner/spi/v1/GapicSpannerRpc.java80.37% <100.00%> (+0.14%)91.00 <0.00> (+2.00)
...m/google/cloud/spanner/connection/SpannerPool.java87.16% <0.00%> (-0.54%)33.00% <0.00%> (ø%)
...ain/java/com/google/cloud/spanner/SessionPool.java89.01% <0.00%> (ø)74.00% <0.00%> (ø%)
...a/com/google/cloud/spanner/SessionPoolOptions.java69.53% <0.00%> (ø)17.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37ca990...ea7dea0. Read the comment docs.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @olavloite

@thiagotnunesthiagotnunes added the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label Apr 29, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label Apr 29, 2021
@thiagotnunesthiagotnunes merged commit f4f9e43 into master Apr 29, 2021
@thiagotnunesthiagotnunes deleted the user-agent-case-insensitive branch April 29, 2021 02:09
Sign up for free to join this conversation on . Already have an account? Sign in to comment
api: spannerIssues related to the googleapis/java-spanner API.cla: yesThis human has signed the Contributor License Agreement.
None yet

Successfully merging this pull request may close these issues.