Conversation

olavloite

An AsyncResultSet that was PAUSED and then CANCELLED, would continue to invoke the callback until the callback would call tryNext(). If the callback never called tryNext(), the spinning would continue until the entire result set had been consumed.

Fixes #1191

@olavloite
fix: stop invoking callback after pausing and cancelling result set
c9c4b94
An AsyncResultSet that was PAUSED and then CANCELLED, would continue to invoke the
callback until the callback would call tryNext(). If the callback never called tryNext(),
the spinning would continue until the entire result set had been consumed.

Fixes #1191
@olavloiteolavloite requested a review from a team as a code owner May 18, 2021 07:22
@google-clagoogle-cla bot added the cla: yesThis human has signed the Contributor License Agreement.label May 18, 2021
@product-auto-labelproduct-auto-label bot added the api: spannerIssues related to the googleapis/java-spanner API.label May 18, 2021
elefeint
elefeint approved these changes May 18, 2021
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verified that this works in R2DBC driver.

@olavloiteolavloite merged commit 78e6784 into master May 19, 2021
@olavloiteolavloite deleted the issue-1191 branch May 19, 2021 08:11
Sign up for free to join this conversation on . Already have an account? Sign in to comment

@thiagotnunes thiagotnunes thiagotnunes approved these changes

@elefeint elefeint elefeint approved these changes

No one assigned
api: spannerIssues related to the googleapis/java-spanner API.cla: yesThis human has signed the Contributor License Agreement.
None yet
No milestone

Successfully merging this pull request may close these issues.

Cancelling and pausing an AsyncResultSet can cause the callback to be called repeatedly