Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The PartitionedDML retry settings were only applied for the RPC, and not for the generic retryer that would retry the PDML transaction if it was aborted by Spanner. This could cause long-running PDML transactions to fail with an Aborted exception. Fixes #199
skuruppu approved these changes May 20, 2020
ejona86 reviewed Jul 9, 2020
| @@ -300,7 +302,7 @@ public GapicSpannerRpc(final SpannerOptions options) { | |||
| // Set a keepalive time of 120 seconds to help long running | |||
| // commit GRPC calls succeed | |||
| .setKeepAliveTime(Duration.ofSeconds(GRPC_KEEPALIVE_SECONDS)) | |||
| .setKeepAliveTime(Duration.ofSeconds(GRPC_KEEPALIVE_SECONDS * 1000)) | |||
There was a problem hiding this comment.
Did you really intend to set the keepalive time to be over a day? This is a value of 120,000 seconds.
There was a problem hiding this comment.
Oops. Thanks for noticing. Nope, that's a typical seconds/milliseconds mistake.
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The PartitionedDML retry settings were only applied for the RPC, and not for the generic retryer that would retry the PDML transaction if it was aborted by Spanner. This could cause long-running PDML transactions to fail with an Aborted exception.
Fixes #199