Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The integration test failures are not related to this change, and will be fixed by #252. The code format failure is as far as I can tell also not related to this change. |
skuruppu approved these changes Jun 10, 2020
Unfortunately, I don't have the permissions to force-merge if required checks fail :( |
The lint problem should be fixed by google-cloud-shared-config 0.7.0 which is releasing now - google-java-format shipped a version incompatible with Java 8 |
olavloite added a commit that referenced this pull request Nov 4, 2020
Some enums were defined as package-private, but these were used in the public API of the Connection API. That made the specific methods in the Connection API unusable from outside the Spanner client library. Towards #253
olavloite added a commit that referenced this pull request Nov 5, 2020
Some enums were defined as package-private, but these were used in the public API of the Connection API. That made the specific methods in the Connection API unusable from outside the Spanner client library. Towards #253
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
* feat: expose more methods from Connection in JDBC More methods from the Connection API should be exposed in the Cloud Spanner JDBC Connection interface to make it easier to execute read-only transactions with specific timestamp bounds. Towards googleapis#253 * clirr: add ignored differences
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Including the google-cloud-spanner test-jar in the bom will allow other libraries to use the test jar without having to specify a version. This again should prevent the kind of failures that we are currently seeing in googleapis/java-spanner-jdbc#142
(The jdbc driver currently defines a specific version for the test-jar in the pom here.)