Conversation

nielm

Replace com.google.common.collect.ImmutableList
with java.util.List

Fixes #410 ☕️

@google-clagoogle-cla bot added the cla: yesThis human has signed the Contributor License Agreement.label Sep 1, 2020
@nielm

@olavloite as he wrote the code I am modifying.
I don't know if the benefits of changing this API surface outweigh the cost of breaking binary compatibility with older library versions...

@product-auto-labelproduct-auto-label bot added the api: spannerIssues related to the googleapis/java-spanner API.label Sep 2, 2020
@nielmnielm changed the title Remove use of Guava types from API surface. Remove Guava ImmutableList from API surface. Sep 8, 2020
@nielm

Updated to only replace ImmutableList -> List to keep JDK 1.7 compatibility.

@olavloite

@nielm You need to add an entry to https://.com/googleapis/java-spanner/blob/master/google-cloud-spanner/clirr-ignored-differences.xml make the clirr plugin stop complaining. Otherwise this LGTM.

Replace com.google.common.collect.ImmutableList
with java.util.List

BREAKING CHANGE
@nielm

@nielm You need to add an entry to https://.com/googleapis/java-spanner/blob/master/google-cloud-spanner/clirr-ignored-differences.xml make the clirr plugin stop complaining. Otherwise this LGTM.

Thanks, Knut, Done!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thiagotnunesthiagotnunes added the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label Sep 10, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label Sep 10, 2020
@thiagotnunesthiagotnunes merged commit b35304e into googleapis:master Sep 10, 2020
ansh0l pushed a commit to ansh0l/java-spanner that referenced this pull request Nov 10, 2022
This is an auto-generated regeneration of the .pb.go files by
cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will
update the corresponding PR to depend on the newer version of go-genproto, and
assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot
will not create any more regeneration PRs. If all regen PRs are closed,
gapicgen will create a new set of regeneration PRs once per night.

If you have been assigned to review this PR, please:

- Ensure that CI is passing. If it's failing, it requires your manual attention.
- Approve and submit this PR if you believe it's ready to ship. That will prompt
genbot to assign reviewers to the google-cloud-go PR.

Corresponding google-cloud-go PR: googleapis/google-cloud-go#2606
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
This is used by autosynth to generate files such as the README.
Sign up for free to join this conversation on . Already have an account? Sign in to comment
api: spannerIssues related to the googleapis/java-spanner API.cla: yesThis human has signed the Contributor License Agreement.
None yet

Successfully merging this pull request may close these issues.

Using Guava classes in AsyncResultSet exposes it on API surface