Conversation

olavloite

Adds additional checks on NUMERIC values before sending them to Cloud Spanner in order to return sensible error messages as soon as possible, and adds documentation on how to handle NUMERIC values with trailing zeros in the fractional part.

@google-clagoogle-cla bot added the cla: yesThis human has signed the Contributor License Agreement.label Sep 14, 2020
@codecov

Codecov Report

Merging #424 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #424      +/-   ##
============================================
+ Coverage     82.16%   82.18%   +0.01%     
- Complexity     2455     2458       +3     
============================================
  Files           136      136              
  Lines         13589    13599      +10     
  Branches       1307     1310       +3     
============================================
+ Hits          11166    11176      +10     
  Misses         1895     1895              
  Partials        528      528              
Impacted FilesCoverage ΔComplexity Δ
.../src/main/java/com/google/cloud/spanner/Value.java87.81% <100.00%> (+0.28%)63.00 <5.00> (+3.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b312091...abb579c. Read the comment docs.

@product-auto-labelproduct-auto-label bot added the api: spannerIssues related to the googleapis/java-spanner API.label Sep 15, 2020
@olavloiteolavloite merged commit 9f26785 into master Sep 18, 2020
@olavloiteolavloite deleted the numeric-range-checks branch September 18, 2020 06:43
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
)

Source-Author: Jeff Ching <[email protected]>
Source-Date: Fri Apr 9 09:18:54 2021 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 5b0e1592dd7d70b485e157ea4b3eb1704ecbd015
Source-Link: googleapis/synthtool@5b0e159
Sign up for free to join this conversation on . Already have an account? Sign in to comment
api: spannerIssues related to the googleapis/java-spanner API.cla: yesThis human has signed the Contributor License Agreement.
None yet

Successfully merging this pull request may close these issues.