Conversation

olavloite

Increases the visibility of AbstractLazyInitializer#get() to make it usable outside the client library.

Replaces #461.

@olavloiteolavloite requested a review from elharo September 30, 2020 14:55
@olavloiteolavloite requested review from a team as code owners September 30, 2020 14:55
@google-clagoogle-cla bot added the cla: yesThis human has signed the Contributor License Agreement.label Sep 30, 2020
@thiagotnunesthiagotnunes added the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label Oct 1, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label Oct 1, 2020
@product-auto-labelproduct-auto-label bot added the api: spannerIssues related to the googleapis/java-spanner API.label Oct 1, 2020
@codecov

Codecov Report

Merging #486 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #486   +/-   ##
=========================================
  Coverage     82.20%   82.20%           
- Complexity     2466     2469    +3     
=========================================
  Files           138      138           
  Lines         13631    13631           
  Branches       1312     1312           
=========================================
+ Hits          11205    11206    +1     
  Misses         1896     1896           
+ Partials        530      529    -1     
Impacted FilesCoverage ΔComplexity Δ
.../google/cloud/spanner/AbstractLazyInitializer.java100.00% <ø> (+7.14%)5.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c13995f...b916df6. Read the comment docs.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do we have to cut a major for this? @olavloite

@olavloite

LGTM, do we have to cut a major for this? @olavloite

I would say no. This only adds visibility, so it should not break anything for anyone.

I would also like to reduce the visibility of the initialize method to protected, which would be a breaking change, but I would prefer to include that change with other breaking changes instead of having to cut a major release just for that.

@olavloiteolavloite merged commit fa6d964 into master Oct 6, 2020
@olavloiteolavloite deleted the increase-visibility-lazyinit-get branch October 6, 2020 09:06
Sign up for free to join this conversation on . Already have an account? Sign in to comment
api: spannerIssues related to the googleapis/java-spanner API.cla: yesThis human has signed the Contributor License Agreement.
None yet

Successfully merging this pull request may close these issues.