Conversation

olavloite

This PR moves the custom Backoff functionality and settings from the SpannerImpl class to AbstractResultSet, as that is the only place where it is still in use.

The Backoff configuration was previously a hard coded value. It now uses the gapic configuration for RPCs as the backoff is only used for the ResumableStreamIterator which is used by the executeSql and Read RPCs.

Updates #20

@googlebotgooglebot added the cla: yesThis human has signed the Contributor License Agreement.label Jan 28, 2020
@olavloiteolavloite merged commit 63b33e9 into master Jan 30, 2020
@olavloiteolavloite deleted the issue-20--result-set branch January 30, 2020 11:05
@yoshi-automationyoshi-automation mentioned this pull request Jan 31, 2020
Merged
@olavloiteolavloite mentioned this pull request Feb 28, 2020
Closed
Sign up for free to join this conversation on . Already have an account? Sign in to comment

@skuruppu skuruppu skuruppu approved these changes

@hengfengli hengfengli Awaiting requested review from hengfengli

No one assigned
cla: yesThis human has signed the Contributor License Agreement.
None yet
No milestone

Successfully merging this pull request may close these issues.