Conversation

thiagotnunes

Creates a jar with dependencies for the snippets samples. This is how we executed the samples in the other repository, so we are mimicking the process here.

Creates a jar with dependencies for the snippets samples. This is how we
executed the samples in the other repository, so we are mimicking the
process here.
@thiagotnunesthiagotnunes requested review from a team as code owners October 27, 2020 22:47
@google-clagoogle-cla bot added the cla: yesThis human has signed the Contributor License Agreement.label Oct 27, 2020
@codecov

Codecov Report

Merging #559 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #559   +/-   ##
=========================================
  Coverage     84.05%   84.05%           
  Complexity     2503     2503           
=========================================
  Files           141      141           
  Lines         13806    13806           
  Branches       1317     1317           
=========================================
  Hits          11604    11604           
  Misses         1656     1656           
  Partials        546      546           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3c96f2...22247ec. Read the comment docs.

@product-auto-labelproduct-auto-label bot added api: spannerIssues related to the googleapis/java-spanner API.samplesIssues that are directly related to samples.labels Oct 28, 2020
<spanner.test.instance>default-instance</spanner.test.instance>
<spanner.sample.database>mysample</spanner.sample.database>
<spanner.quickstart.database>quickstart-db
</spanner.quickstart.database>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could this be one line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this was broken, because of the 80 characters per column checkstyle rule.

@thiagotnunesthiagotnunes merged commit d4ae85c into googleapis:master Oct 28, 2020
@thiagotnunesthiagotnunes deleted the samples-assembly-jar branch October 28, 2020 21:45
ansh0l pushed a commit to ansh0l/java-spanner that referenced this pull request Nov 10, 2022
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
🤖 I have created a release \*beep\* \*boop\*
---
### [2.3.3](https://www..com/googleapis/java-spanner-jdbc/compare/v2.3.2...v2.3.3) (2021-08-19)


### Dependencies

* update dependency com.google.cloud:google-cloud-spanner-bom to v6.11.1 ([googleapis#556](https://www..com/googleapis/java-spanner-jdbc/issues/556)) ([36f0d32](https://www..com/googleapis/java-spanner-jdbc/commit/36f0d32aec65f098f7091d44a0e4acc98104aeb9))
---


This PR was generated with [Release Please](https://.com/googleapis/release-please). See [documentation](https://.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on . Already have an account? Sign in to comment
api: spannerIssues related to the googleapis/java-spanner API.cla: yesThis human has signed the Contributor License Agreement.samplesIssues that are directly related to samples.
None yet

Successfully merging this pull request may close these issues.