Conversation

olavloite

Some enums were defined as package-private, but these were used in the public API of the Connection API. That made the specific methods in the Connection API unusable from outside the Spanner client library.

Towards googleapis/java-spanner-jdbc#253

Some enums were defined as package-private, but these were used in the
public API of the Connection API. That made the specific methods in the
Connection API unusable from outside the Spanner client library.

Towards #253
@olavloiteolavloite requested a review from a team as a code owner November 4, 2020 15:02
@product-auto-labelproduct-auto-label bot added the api: spannerIssues related to the googleapis/java-spanner API.label Nov 4, 2020
@google-clagoogle-cla bot added the cla: yesThis human has signed the Contributor License Agreement.label Nov 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olavloite

Build failures for the samples are not related to this change.

@olavloiteolavloite merged commit 19b1629 into master Nov 5, 2020
@olavloiteolavloite deleted the make-enums-public branch November 5, 2020 10:22
ansh0l pushed a commit to ansh0l/java-spanner that referenced this pull request Nov 10, 2022
This is an auto-generated regeneration of the .pb.go files by
cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will
update the corresponding PR to depend on the newer version of go-genproto, and
assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot
will not create any more regeneration PRs. If all regen PRs are closed,
gapicgen will create a new set of regeneration PRs once per night.

If you have been assigned to review this PR, please:

- Ensure that CI is passing. If it's failing, it requires your manual attention.
- Approve and submit this PR if you believe it's ready to ship. That will prompt
genbot to assign reviewers to the google-cloud-go PR.

Corresponding google-cloud-go PR: googleapis/google-cloud-go#3969

Changes:

chore(oslogin): migrate oslogin/{v1,v1beta} to the PHP microgenerator
  Committer: @miraleung
  PiperOrigin-RevId: 369345532
  Source-Link: googleapis/googleapis@42541de

chore: migrate metastore/v1 to the PHP microgenerator
  Committer: @miraleung
  PiperOrigin-RevId: 369345517
  Source-Link: googleapis/googleapis@7027d3b

chore: migrate chromeos/moblab to the PHP microgenerator
  Committer: @miraleung
  PiperOrigin-RevId: 369345238
  Source-Link: googleapis/googleapis@20ed910

chore: migrate home/graph/v1 to the PHP microgenerator
  Committer: @miraleung
  PiperOrigin-RevId: 369326832
  Source-Link: googleapis/googleapis@b15cf29

chore(monitoring/dasard): migrate monitoring/dasard/v1 to the PHP microgenerator
  Committer: @miraleung
  PiperOrigin-RevId: 369326004
  Source-Link: googleapis/googleapis@59cea2c

chore(translate): migrate translate/{v3,v3beta1} to the PHP microgenerator
  Committer: @miraleung
  PiperOrigin-RevId: 369324550
  Source-Link: googleapis/googleapis@413135d

chore(functions): migrate functions/v1 to the PHP microgenerator
  Committer: @miraleung
  PiperOrigin-RevId: 369324229
  Source-Link: googleapis/googleapis@ccf3501

chore(memcache): migrate memcache/{v1,v1beta2}  to the PHP microgenerator
  Committer: @miraleung
  PiperOrigin-RevId: 369322540
  Source-Link: googleapis/googleapis@05dfbdb

chore(cloudtasks): migrate tasks/{v2,v2beta2,v2beta3} to the PHP microgenerator
  Committer: @miraleung
  PiperOrigin-RevId: 369318406
  Source-Link: googleapis/googleapis@6bf9820

chore(servicedirectory): migrate servicedirectory to the PHP microgenerator
  Committer: @miraleung
  PiperOrigin-RevId: 369317910
  Source-Link: googleapis/googleapis@7ccdb02

chore(iot): migrate iot to the PHP microgenerator
  Committer: @miraleung
  PiperOrigin-RevId: 369317538
  Source-Link: googleapis/googleapis@821f2ac

chore(workflows/executions): migrate workflows/executions/{v1,v1beta} to the PHP microgenerator
  Committer: @miraleung
  PiperOrigin-RevId: 369294024
  Source-Link: googleapis/googleapis@1ff3de9

chore: migrate cloud shell to the PHP microgenerator
  Committer: @miraleung
  PiperOrigin-RevId: 369293908
  Source-Link: googleapis/googleapis@e942763

chore(webrisk): migrate webrisk/{v1,v1beta} to the PHP microgenerator
  Committer: @miraleung
  PiperOrigin-RevId: 369293612
  Source-Link: googleapis/googleapis@0ad68c9

fix(metastore): increase metastore lro polling timeouts
  PiperOrigin-RevId: 369293284
  Source-Link: googleapis/googleapis@d8ef297

chore(scheduler): migrate scheduler/{v1,v1beta1} to the PHP microgenerator
  Committer: @miraleung
  PiperOrigin-RevId: 369288631
  Source-Link: googleapis/googleapis@93a4a58

chore(spanner/admin/instance): migrate Spanner's admin/instance/v1 to the PHP microgenerator
  Committer: @miraleung
  PiperOrigin-RevId: 369288438
  Source-Link: googleapis/googleapis@fc98c27

chore: migrate drive/activity/v2 to the PHP microgenerator
  Committer: @miraleung
  PiperOrigin-RevId: 369287845
  Source-Link: googleapis/googleapis@b64cad0

chore(workflows): migrate workflows/{v1,v1beta}  to the PHP microgenerator
  Committer: @miraleung
  PiperOrigin-RevId: 369287747
  Source-Link: googleapis/googleapis@f82eb08

chore: migrate hostedmarketplace/v2 to the PHP microgenerator
  Committer: @miraleung
  PiperOrigin-RevId: 369287039
  Source-Link: googleapis/googleapis@ffac665

chore(retail): migrate retail/{v2,v2alpha,v2beta} to the PHP microgenerator
  Committer: @miraleung
  PiperOrigin-RevId: 369286800
  Source-Link: googleapis/googleapis@db9e0c1

chore(monitoring/apiv3): migrate monitoring/v3 to the PHP microgenerator
  Committer: @miraleung
  PiperOrigin-RevId: 369286112
  Source-Link: googleapis/googleapis@3b2c21a

chore(datalabeling): migrate datalabeling to the PHP microgenerator
  Committer: @miraleung
  PiperOrigin-RevId: 369279071
  Source-Link: googleapis/googleapis@2e936bf

chore(recommender): migrate recommender/{v1,v1beta} to the PHP microgenerator
  Committer: @miraleung
  PiperOrigin-RevId: 369277106
  Source-Link: googleapis/googleapis@1bf3a28

chore(orgpolicy): migrate orgpolicy/{v1,v2} to the PHP microgenerator
  Committer: @miraleung
  PiperOrigin-RevId: 369275298
  Source-Link: googleapis/googleapis@345f732

chore(recaptchaenterprise): migrate recaptchaenterprise/{v1,v1beta} to the PHP microgenerator
  Committer: @miraleung
  PiperOrigin-RevId: 369274396
  Source-Link: googleapis/googleapis@544f81e

feat: publish serviceusage/v1beta1 API
  Committer: @xiaozhenliu-gg5
  PiperOrigin-RevId: 368882903
  Source-Link: googleapis/googleapis@a8cd11e

feat(billing/budgets): Added support for configurable budget time period. fix: Updated some documentation links.
  PiperOrigin-RevId: 368871890
  Source-Link: googleapis/googleapis@dd6ba75

feat(billing/budgets): Added support for configurable budget time period. fix: Updated some documentation links.
  PiperOrigin-RevId: 368871882
  Source-Link: googleapis/googleapis@24f0828
Sign up for free to join this conversation on . Already have an account? Sign in to comment
api: spannerIssues related to the googleapis/java-spanner API.cla: yesThis human has signed the Contributor License Agreement.
None yet

Successfully merging this pull request may close these issues.