Conversation

olavloite

Adds descriptions for the supported connection URL properties. These can be picked up by the JDBC driver and shown as descriptions for java.sql.DriverPropertyInfo.

Adds descriptions for the supported connection URL properties. These can be
picked up by the JDBC driver and shown as descriptions for java.sql.DriverPropertyInfo.
@olavloiteolavloite requested a review from a team as a code owner November 8, 2020 16:22
@google-clagoogle-cla bot added the cla: yesThis human has signed the Contributor License Agreement.label Nov 8, 2020
@product-auto-labelproduct-auto-label bot added the api: spannerIssues related to the googleapis/java-spanner API.label Nov 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@codecov

Codecov Report

Merging #609 (3bdbe97) into master (c440cd8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #609   +/-   ##
=========================================
  Coverage     84.05%   84.05%           
- Complexity     2502     2503    +1     
=========================================
  Files           141      141           
  Lines         13806    13806           
  Branches       1317     1317           
=========================================
  Hits          11604    11604           
  Misses         1656     1656           
  Partials        546      546           
Impacted FilesCoverage ΔComplexity Δ
...le/cloud/spanner/connection/ConnectionOptions.java86.66% <100.00%> (ø)61.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c440cd8...3bdbe97. Read the comment docs.

@thiagotnunesthiagotnunes merged commit 34221d7 into master Nov 9, 2020
@thiagotnunesthiagotnunes deleted the add-connection-property-descriptions branch November 9, 2020 06:08
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
🤖 I have created a release \*beep\* \*boop\*
---
### Updating meta-information for bleeding-edge SNAPSHOT release.
---


This PR was generated with [Release Please](https://.com/googleapis/release-please). See [documentation](https://.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on . Already have an account? Sign in to comment
api: spannerIssues related to the googleapis/java-spanner API.cla: yesThis human has signed the Contributor License Agreement.
None yet

Successfully merging this pull request may close these issues.