Conversation

olavloite

No description provided.

@olavloiteolavloite added the do not mergeIndicates a pull request not ready for merge, due to either quality or timing.label Nov 19, 2020
@olavloiteolavloite requested a review from a team as a code owner November 19, 2020 19:00
@olavloiteolavloite requested a review from a team November 19, 2020 19:00
@olavloiteolavloite requested a review from a team as a code owner November 19, 2020 19:00
@generated-files-bot

Warning: This pull request is touching the following templated files:

  • ./workflows/approve-readme.yaml
  • ./workflows/auto-release.yaml
  • ./workflows/formatting.yaml
  • google-cloud-spanner/src/test/java/com/google/cloud/spanner/admin/instance/v1/InstanceAdminClientTest.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/java/com/google/spanner/admin/instance/v1/Instance.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/java/com/google/spanner/admin/instance/v1/InstanceOrBuilder.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/java/com/google/spanner/admin/instance/v1/SpannerInstanceAdminProto.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/proto/google/spanner/admin/instance/v1/spanner_instance_admin.proto
  • samples/snippets/pom.xml

@product-auto-labelproduct-auto-label bot added the api: spannerIssues related to the googleapis/java-spanner API.label Nov 19, 2020
@google-clagoogle-cla bot added the cla: yesThis human has signed the Contributor License Agreement.label Nov 19, 2020
@snippet-bot

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

thiagotnunes
thiagotnunes approved these changes Nov 23, 2020
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@generated-files-bot

Warning: This pull request is touching the following templated files:

  • google-cloud-spanner/src/test/java/com/google/cloud/spanner/admin/instance/v1/InstanceAdminClientTest.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/java/com/google/spanner/admin/instance/v1/Instance.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/java/com/google/spanner/admin/instance/v1/InstanceOrBuilder.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/java/com/google/spanner/admin/instance/v1/SpannerInstanceAdminProto.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/proto/google/spanner/admin/instance/v1/spanner_instance_admin.proto

elharo
elharo suggested changes Jan 21, 2021
View reviewed changes
@generated-files-bot

Warning: This pull request is touching the following templated files:

  • google-cloud-spanner/src/test/java/com/google/cloud/spanner/admin/instance/v1/InstanceAdminClientTest.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/java/com/google/spanner/admin/instance/v1/Instance.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/java/com/google/spanner/admin/instance/v1/InstanceOrBuilder.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/java/com/google/spanner/admin/instance/v1/SpannerInstanceAdminProto.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/proto/google/spanner/admin/instance/v1/spanner_instance_admin.proto

@codecov

Codecov Report

Merging #665 (b164d50) into master (cd45643) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head b164d50 differs from pull request most recent head 5c462ae. Consider uploading reports for the commit 5c462ae to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master     #665      +/-   ##
============================================
+ Coverage     84.86%   84.91%   +0.04%     
- Complexity     2762     2769       +7     
============================================
  Files           156      156              
  Lines         14318    14335      +17     
  Branches       1377     1379       +2     
============================================
+ Hits          12151    12172      +21     
+ Misses         1596     1592       -4     
  Partials        571      571
Impacted FilesCoverage Δ
...c/main/java/com/google/cloud/spanner/Instance.java82.25% <100.00%> (+0.90%)⬆️
.../google/cloud/spanner/InstanceAdminClientImpl.java89.87% <100.00%> (+0.39%)⬆️
...in/java/com/google/cloud/spanner/InstanceInfo.java97.91% <100.00%> (+2.62%)⬆️
...a/com/google/cloud/spanner/SessionPoolOptions.java69.53% <0.00%> (ø)
...ain/java/com/google/cloud/spanner/SessionPool.java88.75% <0.00%> (+0.20%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e1df84...5c462ae. Read the comment docs.

@olavloiteolavloite requested a review from elharo February 4, 2021 10:08
@google-cla

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-clagoogle-cla bot added cla: noThis human has *not* signed the Contributor License Agreement.and removed cla: yesThis human has signed the Contributor License Agreement.labels May 6, 2021
@google-clagoogle-cla bot added cla: yesThis human has signed the Contributor License Agreement.and removedThis human has *not* signed the Contributor License Agreement.labels May 6, 2021
@thiagotnunes
test: fixes instanceinfo test
4a3f44b
Due to master merge the compilation was failing. Fixes the builder
construction here.
@thiagotnunes
Merge branch 'master' of .com:googleapis/java-spanner into proc…
1ecd9f6
…essing-units
@thiagotnunes
refactor: adds default impl for processing units
657f210
Adds default implementation for the InstanceInfo set processing units in
order to avoid a breaking change.
@thiagotnunes
samples: remove LCI samples for now
dc17892
Removes the LCI samples for now, because they won't compile. We will
re-add them once the main implementation is released.
elharo
elharo reviewed Jun 16, 2021
View reviewed changes
@thiagotnunesthiagotnunes requested a review from elharo June 18, 2021 01:11
@thiagotnunesthiagotnunes removed the do not mergeIndicates a pull request not ready for merge, due to either quality or timing.label Jun 21, 2021
@thiagotnunesthiagotnunes merged commit 9c1c8e9 into master Jun 21, 2021
@thiagotnunesthiagotnunes deleted the processing-units branch June 21, 2021 01:22
ansh0l pushed a commit to ansh0l/java-spanner that referenced this pull request Nov 10, 2022
@yoshi-automation
chore(all): auto-regenerate .pb.go files (googleapis#665)
66f60bf
This is an auto-generated regeneration of the .pb.go files by
cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will
update the corresponding PR to depend on the newer version of go-genproto, and
assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot
will not create any more regeneration PRs. If all regen PRs are closed,
gapicgen will create a new set of regeneration PRs once per night.

If you have been assigned to review this PR, please:

- Ensure that CI is passing. If it's failing, it requires your manual attention.
- Approve and submit this PR if you believe it's ready to ship. That will prompt
genbot to assign reviewers to the google-cloud-go PR.

Corresponding google-cloud-go PR: googleapis/google-cloud-go#4689

Changes:

feat(gaming): support version reporting API
  PiperOrigin-RevId: 393476621
  Source-Link: googleapis/googleapis@e9da6f8

chore: update gapic-generator-ruby to 0.10.1
  Committer: @virost
  PiperOrigin-RevId: 393450219
  Source-Link: googleapis/googleapis@41635ad
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
@release-please
chore: release 2.5.2 (googleapis#665)
26edf64
🤖 I have created a release \*beep\* \*boop\*
---
### [2.5.2](https://www..com/googleapis/java-spanner-jdbc/compare/v2.5.1...v2.5.2) (2021-11-11)


### Dependencies

* update dependency com.google.cloud:google-cloud-spanner-bom to v6.15.2 ([googleapis#664](https://www..com/googleapis/java-spanner-jdbc/issues/664)) ([9f22c33](https://www..com/googleapis/java-spanner-jdbc/commit/9f22c331ee4c7340ed6f1b9f91a44ce1e4c5b792))
---


This PR was generated with [Release Please](https://.com/googleapis/release-please). See [documentation](https://.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on . Already have an account? Sign in to comment

@thiagotnunes thiagotnunes thiagotnunes approved these changes

@skuruppu skuruppu skuruppu approved these changes

@elharo elharo elharo approved these changes

No one assigned
api: spannerIssues related to the googleapis/java-spanner API.cla: yesThis human has signed the Contributor License Agreement.
None yet
No milestone

Successfully merging this pull request may close these issues.