Conversation

Strykrol

These samples' region tags slightly differ from identical snippets in different languages. The following is the remedy:

  1. Merge this PR to fix source (keep old tag for now)
  2. Fix doc code includes to represent the better region tag
  3. Submit a second PR to clean-up redundant region tag wrapping

@StrykrolStrykrol requested a review from a team as a code owner December 15, 2020 21:41
@StrykrolStrykrol requested a review from a team December 15, 2020 21:41
@google-clagoogle-cla bot added the cla: yesThis human has signed the Contributor License Agreement.label Dec 15, 2020
@product-auto-labelproduct-auto-label bot added the api: spannerIssues related to the googleapis/java-spanner API.label Dec 15, 2020
@snippet-bot

Here is the summary of changes.

You added 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@codecov

Codecov Report

Merging #752 (7fce014) into master (daef458) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #752      +/-   ##
============================================
- Coverage     85.15%   85.15%   -0.01%     
+ Complexity     2564     2563       -1     
============================================
  Files           142      142              
  Lines         13952    13960       +8     
  Branches       1331     1331              
============================================
+ Hits          11881    11887       +6     
- Misses         1512     1514       +2     
  Partials        559      559              
Impacted FilesCoverage ΔComplexity Δ
.../google/cloud/spanner/SpannerExceptionFactory.java82.47% <0.00%> (-2.07%)46.00% <0.00%> (-1.00%)
...m/google/cloud/spanner/spi/v1/GapicSpannerRpc.java83.39% <0.00%> (+0.17%)81.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daef458...7fce014. Read the comment docs.

@StrykrolStrykrol force-pushed the standardizeRegionTags branch from 95b6902 to 7fce014 Compare December 15, 2020 22:28
@skuruppuskuruppu added kokoro:force-runAdd this label to force Kokoro to re-run the tests.automergeMerge the pull request once unit tests and other checks pass.labels Dec 15, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label Dec 15, 2020
@gcf-merge-on-greengcf-merge-on-green bot merged commit 2b3775a into googleapis:master Dec 15, 2020
@gcf-merge-on-greengcf-merge-on-green bot removed the automergeMerge the pull request once unit tests and other checks pass.label Dec 15, 2020
thiagotnunes pushed a commit that referenced this pull request May 6, 2021
These samples' region tags slightly differ from identical snippets in different languages. The following is the remedy:

1. Merge this PR to fix  source (keep old tag for now)
2. Fix doc code includes to represent the better region tag
3. Submit a second PR to clean-up redundant region tag wrapping
ansh0l pushed a commit to ansh0l/java-spanner that referenced this pull request Nov 10, 2022
This is an auto-generated regeneration of the .pb.go files by
cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will
update the corresponding PR to depend on the newer version of go-genproto, and
assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot
will not create any more regeneration PRs. If all regen PRs are closed,
gapicgen will create a new set of regeneration PRs once per night.

If you have been assigned to review this PR, please:

- Ensure that CI is passing. If it's failing, it requires your manual attention.
- Approve and submit this PR if you believe it's ready to ship. That will prompt
genbot to assign reviewers to the google-cloud-go PR.

Corresponding google-cloud-go PR: googleapis/google-cloud-go#5449

Changes:

chore: use gapic-generator-python 0.63.1
  docs: add autogenerated code snippets
  PiperOrigin-RevId: 426256923
  Source-Link: googleapis/googleapis@9ebabfa

chore(ruby): Regenerate using Ruby microgenerator 0.10.6
  PiperOrigin-RevId: 426223384
  Source-Link: googleapis/googleapis@e34d712

feat(channel): Change description for GCP ProvisionedService.provisioning_id value feat: Update year from 2021 to 2022
  PiperOrigin-RevId: 426206624
  Source-Link: googleapis/googleapis@4eca5ca

chore: regenerate API index

  Source-Link: googleapis/googleapis@66759bd

feat(documentai): add question_id field in ReviewDocumentOperationMetadata
  PiperOrigin-RevId: 426180523
  Source-Link: googleapis/googleapis@38a8eb9
Sign up for free to join this conversation on . Already have an account? Sign in to comment
api: spannerIssues related to the googleapis/java-spanner API.cla: yesThis human has signed the Contributor License Agreement.
None yet

Successfully merging this pull request may close these issues.